Fix: bump Go SDK module version to /v3#4075
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the Go module version references from v2 to v3 and adds a test to catch version mismatches.
- Update constant values in schema.go (goBasePath and goModuleVersion) to reflect v3.
- Update the import path pattern in the schema generation to incorporate the new version.
- Add TestGoModuleVersionMatches in schema_test.go to verify the Go module version consistency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| provider/pkg/gen/schema_test.go | Introduces a test case to validate the updated Go module version. |
| provider/pkg/gen/schema.go | Updates constants and import path pattern to bump module version. |
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
38ee336 to
c705b81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4075 +/- ##
=========================================
Coverage ? 58.05%
=========================================
Files ? 84
Lines ? 13514
Branches ? 0
=========================================
Hits ? 7846
Misses ? 5077
Partials ? 591 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
41a5d27 to
1be1e47
Compare
…ndardizing on latest v3.160
6ec9c72 to
731a7d0
Compare
danielrbradley
approved these changes
Apr 7, 2025
Contributor
|
This PR has been shipped in release v3.0.1. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was forgotten when releasing v3 of the provider. Added a test to catch this next time.
go getupgraded p/p, so I upgraded it everywhere to avoid errors due to version conflicts.The bump of the two upgrade tests wasn't necessary but now that it's done I decided to leave it in.
For the record: some of the Go integration tests in examples/ didn't have
replacedirectives for azure native. That should be fine for test execution since examples_go_test generates the correct replacements at runtime. However, due to the missing replacements,go mod tidykept an indirect reference to the v2 sdk, which then broke the runtime replacement generation:go mod edit -replace github.com/pulumi/pulumi-azure-native-sdk/----->v2<-----=/home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/pulumi-azure-native-sdk'