Skip to content

Fix: bump Go SDK module version to /v3#4075

Merged
thomas11 merged 8 commits into
masterfrom
tkappler/v3-go-version
Apr 7, 2025
Merged

Fix: bump Go SDK module version to /v3#4075
thomas11 merged 8 commits into
masterfrom
tkappler/v3-go-version

Conversation

@thomas11

@thomas11 thomas11 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

This was forgotten when releasing v3 of the provider. Added a test to catch this next time.

go get upgraded p/p, so I upgraded it everywhere to avoid errors due to version conflicts.

The bump of the two upgrade tests wasn't necessary but now that it's done I decided to leave it in.

For the record: some of the Go integration tests in examples/ didn't have replace directives for azure native. That should be fine for test execution since examples_go_test generates the correct replacements at runtime. However, due to the missing replacements, go mod tidy kept an indirect reference to the v2 sdk, which then broke the runtime replacement generation:
go mod edit -replace github.com/pulumi/pulumi-azure-native-sdk/----->v2<-----=/home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/pulumi-azure-native-sdk'

@thomas11 thomas11 requested review from a team, Copilot and danielrbradley April 2, 2025 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Go module version references from v2 to v3 and adds a test to catch version mismatches.

  • Update constant values in schema.go (goBasePath and goModuleVersion) to reflect v3.
  • Update the import path pattern in the schema generation to incorporate the new version.
  • Add TestGoModuleVersionMatches in schema_test.go to verify the Go module version consistency.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
provider/pkg/gen/schema_test.go Introduces a test case to validate the updated Go module version.
provider/pkg/gen/schema.go Updates constants and import path pattern to bump module version.

@github-actions

github-actions Bot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov

codecov Bot commented Apr 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@33c6fef). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4075   +/-   ##
=========================================
  Coverage          ?   58.05%           
=========================================
  Files             ?       84           
  Lines             ?    13514           
  Branches          ?        0           
=========================================
  Hits              ?     7846           
  Misses            ?     5077           
  Partials          ?      591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas11 thomas11 force-pushed the tkappler/v3-go-version branch from 41a5d27 to 1be1e47 Compare April 2, 2025 14:22
@thomas11 thomas11 force-pushed the tkappler/v3-go-version branch from 6ec9c72 to 731a7d0 Compare April 7, 2025 08:04
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v3.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants