Only initialize custom resources if provider is not parameterized#4030
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4030 +/- ##
==========================================
+ Coverage 57.84% 57.85% +0.01%
==========================================
Files 83 83
Lines 13369 13375 +6
==========================================
+ Hits 7733 7738 +5
- Misses 5037 5038 +1
Partials 599 599 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielrbradley
approved these changes
Mar 17, 2025
thomas11
force-pushed
the
tkappler/parameterize-customresources-2
branch
from
4f2ef65 to
f8967b7
Compare
thomas11
force-pushed
the
tkappler/parameterize-customresources-2
branch
from
4963b1a to
14b7783
Compare
thomas11
added a commit
that referenced
this pull request
Mar 18, 2025
…resource to parameterized (#4032) This integration test proves that 1. `pulumi package add` works and produces a usable SDK, 2. users can migrate from a default resource (here, a storage account) to a parameterized one without replacement, and 3. the default provider and parameterized ones can be used in the same program without issues. **This PR contains and requires #4030, otherwise the test will fail.**
Contributor
|
This PR has been shipped in release v2.89.2. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.