Generate a default API versions only schema and use it for sdkgen in version 3+#4016
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4016 +/- ##
==========================================
- Coverage 57.76% 57.67% -0.10%
==========================================
Files 82 82
Lines 13144 13156 +12
==========================================
- Hits 7593 7588 -5
- Misses 4974 4991 +17
Partials 577 577 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thomas11
force-pushed
the
tkappler/v3-default-only
branch
from
00b632f to
57d8683
Compare
thomas11
added a commit
that referenced
this pull request
Mar 18, 2025
This is a follow-up to #4016 where I had forgotten that Go SDK generation works differently than the other languages. Fortunately, the code already accepts the required arguments, we just need to pass them. This PR has no effect on the SDK in v2.x, only in v3.x. I wonder if we should remove the "default" schema location altogether and just make the argument mandatory.
Contributor
|
This PR has been shipped in release v2.89.2. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For v3 of the provider, we want to generate SDKs only for the default API versions. However, to enable parameterization to generate SDKs for any API version at runtime, we need the full schema and metadata. This PR adds a build step of generating a default-versions-only schema that's then used to generate the SDKs. The full schema is embedded into the provider as before.
A branch with this PR but regenerated for
PROVIDER_VERSION=3.0.0is here.Resolves #3422