Skip to content

GH-3963: Allow user to specify audience for OIDC authentication#3970

Merged
thomas11 merged 1 commit into
masterfrom
tkappler/robcao/oidc-audience
Feb 20, 2025
Merged

GH-3963: Allow user to specify audience for OIDC authentication#3970
thomas11 merged 1 commit into
masterfrom
tkappler/robcao/oidc-audience

Conversation

@thomas11

@thomas11 thomas11 commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

This PR is a copy of #3965 by @robcao, to make CI tests run. Original description:


This pull request is a potential implementation for #3963

It adds a new configuration variable for the auth_azidentity module, ARM_OIDC_AUDIENCE.

When specified, the value of ARM_OIDC_AUDIENCE will be used when making a request for a federated token. If not specified, the audience will default to api://AzureADTokenExchange like currently.

@thomas11 thomas11 requested review from a team and danielrbradley February 19, 2025 16:45
@github-actions

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov

codecov Bot commented Feb 19, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.29%. Comparing base (0e2299b) to head (a72a320).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/provider/auth_azidentity.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3970      +/-   ##
==========================================
- Coverage   57.30%   57.29%   -0.01%     
==========================================
  Files          80       80              
  Lines       12720    12725       +5     
==========================================
+ Hits         7289     7291       +2     
- Misses       4871     4873       +2     
- Partials      560      561       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 merged commit 68c1a11 into master Feb 20, 2025
@thomas11 thomas11 deleted the tkappler/robcao/oidc-audience branch February 20, 2025 05:26
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.89.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants