Fix schema generation when run under path with dots

[tie]

This change fixes schema generation when specifications path contains dots (e.g. /build/pulumi-azure-native-2.88.0/azure-rest-api-specs/…).

I assume this a regression introduced in #3872 (comment), cc @danielrbradley.

[github-actions]

Hi there 👋 Thank you for submitting a pull request.

Acceptance tests must be run by a maintainer. If a maintainer hasn't picked this up after 7 days, please do reach out to a maintainer via our community Slack.

Maintainers: Please review changes then run tests by adding the comment:

/run-acceptance-tests

[thomas11]

Hi @tie, thank you for your contribution! I can see how if strings.Contains(part, ".") would falsely match any dots in the path.

Would you mind adding some unit tests to resources_test.go? That way we can also make sure the new code doesn't regress anything. Some edge cases to watch out for are parameters with dots (/{foo.bar}) and nested /specification/, as you point out in your comment.

[thomas11]

/run-acceptance-tests

[pulumi-bot]

Please view the PR build: https://github.com/pulumi/pulumi-azure-native/actions/runs/13419773681

[thomas11]

Hi @tie, just checking back in if you'd be up for adding some tests? We'd love to have your contribution.

[tie]

@thomas11, hi, sorry for the late reply! Added two test cases for GetModuleName.

[thomas11]

Running make schema shows an unexpected difference in versions/v2.yaml. A few resources seem to be missing. I haven't investigated yet.

[tie]

Looks like folderModulePattern regexp does not allow numbers, e.g.

/go/pulumi-azure-native/azure-rest-api-specs/specification/storsimple8000series/resource-manager/Microsoft.StorSimple/stable/2017-06-01/storsimple.json

[thomas11]

LGTM, thank you!

[pulumi-bot]

This PR has been shipped in release v2.89.2.