Skip to content

Type AzureClient.GET response more explicitly#3957

Merged
thomas11 merged 1 commit into
masterfrom
tkappler/azureclient-get
Feb 21, 2025
Merged

Type AzureClient.GET response more explicitly#3957
thomas11 merged 1 commit into
masterfrom
tkappler/azureclient-get

Conversation

@thomas11

Copy link
Copy Markdown
Contributor

A small fix that I discovered by accident. The API returned any but it's always a map[string]any, and some callers blindly typecast anyway. Typing it explicitly simplifies some client code.

@thomas11 thomas11 requested a review from a team February 17, 2025 14:44
@github-actions

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov

codecov Bot commented Feb 17, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.51%. Comparing base (3490828) to head (dd19e30).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/provider/crud/crud.go 0.00% 3 Missing ⚠️
provider/pkg/azure/client.go 33.33% 2 Missing ⚠️
provider/pkg/provider/provider.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3957      +/-   ##
==========================================
+ Coverage   57.49%   57.51%   +0.01%     
==========================================
  Files          82       82              
  Lines       13078    13074       -4     
==========================================
  Hits         7519     7519              
+ Misses       4984     4981       -3     
+ Partials      575      574       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.89.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants