Type AzureClient.GET response more explicitly#3957
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3957 +/- ##
==========================================
+ Coverage 57.49% 57.51% +0.01%
==========================================
Files 82 82
Lines 13078 13074 -4
==========================================
Hits 7519 7519
+ Misses 4984 4981 -3
+ Partials 575 574 -1 ☔ View full report in Codecov by Sentry. |
a905f77 to
a665dc9
Compare
rquitales
approved these changes
Feb 21, 2025
a665dc9 to
dd19e30
Compare
Contributor
|
This PR has been shipped in release v2.89.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small fix that I discovered by accident. The API returned
anybut it's always amap[string]any, and some callers blindly typecast anyway. Typing it explicitly simplifies some client code.