Skip to content

Restructure v3 modules#3918

Merged
danielrbradley merged 8 commits into
masterfrom
restructure-v3-modules
Jan 31, 2025
Merged

Restructure v3 modules#3918
danielrbradley merged 8 commits into
masterfrom
restructure-v3-modules

Conversation

@danielrbradley

Copy link
Copy Markdown
Contributor

Addresses the most prominent cases from #690

These changes have been previewed against the temporary v3-module-restructure-preview branch to be able to see the impact of each rename. Individual commits are linked below and show the files moving and the old-module aliases being added to each resource.

@github-actions

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov

codecov Bot commented Jan 31, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.03%. Comparing base (f1cae56) to head (f431e59).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3918   +/-   ##
=======================================
  Coverage   57.03%   57.03%           
=======================================
  Files          79       79           
  Lines       12549    12548    -1     
=======================================
  Hits         7157     7157           
+ Misses       4841     4840    -1     
  Partials      551      551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'll probably need to re-do my PR #3917 but should be easy enough.

@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants