Sort (and deduplicate) type aliases#3902
Merged
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3902 +/- ##
=======================================
Coverage 57.06% 57.06%
=======================================
Files 78 78
Lines 12469 12470 +1
=======================================
+ Hits 7115 7116 +1
Misses 4807 4807
Partials 547 547 ☔ View full report in Codecov by Sentry. |
thomas11
approved these changes
Jan 28, 2025
- Use a set to ensure we don't add duplicate aliases. - Render the aliases ordered. This just affects explicit versions, moving the default version from the first alias to the last in the list. This will allow us to add additional sources of aliases (from the previous major version) without causing duplicates.
danielrbradley
force-pushed
the
sort-aliases
branch
from
4831084 to
93c9cb7
Compare
Contributor
|
This PR has been shipped in release v2.85.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just affects explicit versions, moving the default version from the first alias to the last in the list.
This will allow us to add additional sources of aliases (from the previous major version) without causing duplicates.