A new report listing API versions that are old enough to be removed#3899
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
danielrbradley
left a comment
danielrbradley
left a comment
Contributor
There was a problem hiding this comment.
Overall approach looks sensible 👍
The main algorithm could do with a couple of comments helping explain the rational of each major step.
Also, looks like there's a diff in the generated file in CI that we'll need to resolve.
danielrbradley
approved these changes
Jan 28, 2025
danielrbradley
left a comment
danielrbradley
left a comment
Contributor
There was a problem hiding this comment.
Looks good, minor nit inline, also could add a line to the reports/README.md to explain the purpose of the new report.
thomas11
force-pushed
the
tkappler/old-versions-report
branch
from
aff35af to
af0e097
Compare
Co-authored-by: Daniel Bradley <daniel@pulumi.com>
thomas11
force-pushed
the
tkappler/old-versions-report
branch
from
af0e097 to
748290f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3899 +/- ##
==========================================
- Coverage 57.21% 57.05% -0.16%
==========================================
Files 78 78
Lines 12436 12469 +33
==========================================
- Hits 7115 7114 -1
- Misses 4774 4808 +34
Partials 547 547 ☔ View full report in Codecov by Sentry. |
Closed
Contributor
|
This PR has been shipped in release v2.85.0. |
thomas11
added a commit
that referenced
this pull request
Jan 31, 2025
#3899 introduced a report of all API versions, per module, that are older than the lowest default version of that module in the previous major version. This PR takes that report for v2 -> v3 and merges it into v3-removed.json, to remove these old API versions. The size of the `sdk/` folder went from 3g to 1.4g on my machine. Applying oldApiVersions.json to v3-removed.json was done with a little program generated by Cursor: ```py import json # Load the JSON files with open('reports/oldApiVersions.json', 'r') as old_file: old_versions = json.load(old_file) with open('versions/v3-removed.json', 'r') as v3_file: v3_versions = json.load(v3_file) # Merge the dictionaries for key, versions in old_versions.items(): if key in v3_versions: # Merge and sort the version arrays v3_versions[key] = sorted(set(v3_versions[key] + versions)) else: # Add new key and versions v3_versions[key] = sorted(versions) # Write the merged dictionary back to v3-removed.json with open('v3-removed.json', 'w') as v3_file: json.dump(v3_versions, v3_file, indent=2) ```
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3422. Determine API versions that are older than any previous default version in a module. These are good candidates for removal.