[v3] Skip flattening if properties would clash - PR #2

[thomas11]

Skip the flattening of nested properties indicated by x-ms-client-flatten if it would lead to overwriting a property, creating incorrect schema and SDKs. This case happens when inner and outer property have the same name. For a report on all occurrences see #3013.

This change is breaking and could therefore only be applied to v3 of the provider.

The PR is written to be reviewed commit by commit. It supersedes the previous #3801. I recommend hiding whitespace when reviewing since the level of indentation of otherwise unaffected code changed.

Resolves #3195

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[codecov]

Codecov Report

Attention: Patch coverage is 56.36364% with 24 lines in your changes missing coverage. Please review.

Project coverage is 56.96%. Comparing base (b5b0a21) to head (12227e6).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
provider/pkg/gen/properties.go	56.36%	21 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3839      +/-   ##
==========================================
- Coverage   57.00%   56.96%   -0.04%     
==========================================
  Files          78       78              
  Lines       12035    12062      +27     
==========================================
+ Hits         6860     6871      +11     
- Misses       4675     4691      +16     
  Partials      500      500              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danielrbradley]

:chefkiss: Let's make sure to not squash!

[thomas11]

@danielrbradley I forgot in the PR description: I rebuilt everything pretending to be on v3 (editing the boolean condition). Branch tkappler/v3-skip-flattening-2-v3gen contains the result, just for inspection, not to be merged.

[danielrbradley]

Cool that looks spot on. (Direct link to commit: 2f823f5)

[pulumi-bot]

This PR has been shipped in release v2.82.0.