Skip to content

Fix flaky TestAccSimpleTs test#3830

Merged
thomas11 merged 5 commits into
masterfrom
tkappler/webappslot-fixes
Jan 2, 2025
Merged

Fix flaky TestAccSimpleTs test#3830
thomas11 merged 5 commits into
masterfrom
tkappler/webappslot-fixes

Conversation

@thomas11

@thomas11 thomas11 commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

Hopefully fix the very flaky test TestAccSimpleTs. Fixes #3813.

I ran this version of the test in a loop and it succeeded 16 times in a row (each run is 5-6 minutes).

Commits are logically separate:

  • Update examples to latest p/p
  • Show diff when test fails preview
  • WebAppSlot bugfix: look up correct resource. Most likely had no impact.
  • Update ignoreChanges for siteConfig in WebApp/WebAppSlot to ensure proper handling of site configuration during refresh-update cycles.

@thomas11 thomas11 requested review from a team and danielrbradley January 2, 2025 16:23
@github-actions

github-actions Bot commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@mjeffryes mjeffryes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread examples/simple/index.ts
@codecov

codecov Bot commented Jan 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.01%. Comparing base (7555e20) to head (14589ea).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...der/pkg/resources/customresources/custom_webapp.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3830   +/-   ##
=======================================
  Coverage   57.01%   57.01%           
=======================================
  Files          78       78           
  Lines       12041    12041           
=======================================
  Hits         6865     6865           
  Misses       4676     4676           
  Partials      500      500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.81.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration test TestAccSimpleTs is flaky

3 participants