azcore fix: initialize request pipeline with configured cloud#3802
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3802 +/- ##
==========================================
+ Coverage 57.00% 57.01% +0.01%
==========================================
Files 78 78
Lines 12035 12041 +6
==========================================
+ Hits 6860 6865 +5
- Misses 4675 4676 +1
Partials 500 500 ☔ View full report in Codecov by Sentry. |
mjeffryes
approved these changes
Dec 17, 2024
mjeffryes
left a comment
mjeffryes
left a comment
Contributor
There was a problem hiding this comment.
Approving b/c I don't want to block you on timezone delta and it makes sense that this could fix the issue, but would be nice to capture this requirement in some sort of test or at least a comment.
thomas11
force-pushed
the
tkappler/azcore-token-scope
branch
from
3bd6a92 to
89e784c
Compare
Contributor
|
This PR has been shipped in release v2.79.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3795, hopefully.
The way Azure's azcore and azidentity SDKs are designed makes it hard to test this, but reading the source here it looks like this change should fix the issue.