Improve module naming testing & reporting#3790
Merged
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3790 +/- ##
==========================================
+ Coverage 56.96% 57.00% +0.03%
==========================================
Files 78 78
Lines 12018 12029 +11
==========================================
+ Hits 6846 6857 +11
- Misses 4672 4673 +1
+ Partials 500 499 -1 ☔ View full report in Codecov by Sentry. |
thomas11
reviewed
Dec 13, 2024
thomas11
left a comment
Contributor
There was a problem hiding this comment.
Why do most of the reports in the PR descriptions lack Path and FilePath?
Contributor
Author
That's just poor formatting on my side ... i.e. it's
|
thomas11
approved these changes
Dec 14, 2024
These are absolute at runtime, so should be reflected in the test.
This is the "new style" but it's opt-in for only a specific list of modules.
- Add error return from ResourceProvider naming function. - Add entry to DiscoveryDiagnostics & BuildSchemaReports.
f2ca6a4 to
d8ad612
Compare
Contributor
|
This PR has been shipped in release v2.78.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards: #690
Summary of report findings where file and uri calculated names don't match
file:
Authorization, uri:""Count: 31
file:
KeyVault, uri:ResourcesCount: 16
###: file:
Maps, uri:ResourcesCount: 2
file:
Network, uri:ComputeCount: 522
File paths:
specification/network/resource-manager/Microsoft.Network/*/*/vmssPublicIpAddress.json:Resource paths:
providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/.../ipConfigurations/{ipConfigurationName}"file:
NotificationHubs, uri:""Count: 1
file:
PowerBI, uri:ResourcesCount: 1
file:
Authorization, uri:""Count: 31
Path: "/{policyAssignmentId}"
file:
Resources, uri:AuthorizationCount: 6
Path: ".../providers/Microsoft.Authorization/policyAssignments"
file:
Resources, uri:""Count: 52
Path: "/providers" or "/{resourceId}"
file:
Resources, uri:ManagementCount: 9
Path: "/providers/Microsoft.Management/managementGroups/{groupId}/providers/{resourceProviderNamespace}/register
file:
Solutions, uri:""Count: 18
Path: "/{applicationId}"
file:
SaaS, uri:ResourcesCount: 2
Path: "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/moveResources|validateMoveResources"
file:
Web, uri:CertificateRegistrationCount: 12
file:
Web, uri:DomainRegistrationCount: 11
file:
Web, uri:ResourcesCount: 33
Web, uri:CertificateRegistrationCount: 12