Implement autonaming configuration protocol#3779
Merged
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3779 +/- ##
==========================================
+ Coverage 56.70% 56.95% +0.25%
==========================================
Files 78 78
Lines 11999 12018 +19
==========================================
+ Hits 6804 6845 +41
+ Misses 4692 4673 -19
+ Partials 503 500 -3 ☔ View full report in Codecov by Sentry. |
fff19ab to
9f024e3
Compare
9f024e3 to
0b5be01
Compare
0b5be01 to
c013e93
Compare
danielrbradley
left a comment
Contributor
There was a problem hiding this comment.
Core implementation looks okay, would like to see the tests alongside where our existing yaml test are.
31c1495 to
2ec1294
Compare
danielrbradley
approved these changes
Dec 13, 2024
Contributor
|
This PR has been shipped in release v2.78.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement the Azure Native part of pulumi/pulumi#1518. See pulumi/pulumi#17592 for the full design.
In short, pulumi/pulumi#17810 introduced the protobuf changes required for the provider-side implementation. With those, a provider can:
This PR applies those parameters to auto-name calculation if they are specified:
Added unit tests to cover most autonaming cases (old or new). Also, added an end-to-end test in YAML.
Resolves #3777