Generalise version in the makefile#3770
Merged
Merged
Conversation
danielrbradley
commented
Dec 10, 2024
danielrbradley
commented
Contributor
- Remove hard-coded version numbers for the versions files. Calculate MAJOR_VERSION, NEXT_MAJOR_VERSION and PREVIOUS_MAJOR_VERSION
- Use same format for removed-resources for the previous, current and next version (JSON).
- Add missing dependencies for when building the schema.
- Remove hard-coded version numbers for the versions files. Calculate MAJOR_VERSION, NEXT_MAJOR_VERSION and PREVIOUS_MAJOR_VERSION - Use same format for removed-resources for the previous, current and next version (JSON). - Add missing dependencies for when building the schema.
We need pulumictl installed before calling that variable, so we can't use the variable for calculating dependencies. In practice, the PROVIDER_VERSION never starts with a "v" now, so we don't really need to normalise it.
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
thomas11
approved these changes
Dec 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3770 +/- ##
==========================================
- Coverage 56.66% 56.65% -0.01%
==========================================
Files 77 77
Lines 11954 11954
==========================================
- Hits 6774 6773 -1
- Misses 4682 4683 +1
Partials 498 498 ☔ View full report in Codecov by Sentry. |
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
Contributor
|
This PR has been shipped in release v2.77.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.