Skip to content

StaticSiteLinkedBackend has a non-required property 'region' that is required in the API#3759

Merged
thomas11 merged 2 commits into
masterfrom
tkappler/StaticSiteLinkedBackend-region
Dec 9, 2024
Merged

StaticSiteLinkedBackend has a non-required property 'region' that is required in the API#3759
thomas11 merged 2 commits into
masterfrom
tkappler/StaticSiteLinkedBackend-region

Conversation

@thomas11

@thomas11 thomas11 commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Resolves #3757

If I don't specifiy the region of the static site linked backend, the program fails with an Internal Server Error.
The Region property should be mandatory (at least when used with an App Service backend).

Pulumi does not automatically fill the region with the default Azure location, probably because it's called Region and not Location, or maybe because it should be filled with the App Service location.

@thomas11 thomas11 self-assigned this Dec 9, 2024
@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Found 1 breaking change:

Resources

  • 🟢 "azure-native:web:StaticSiteLinkedBackend": required inputs: "region" input has changed to Required
    No new resources/functions.

@codecov

codecov Bot commented Dec 9, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.78%. Comparing base (f189550) to head (3f9d4d1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/gen/schema.go 28.57% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3759      +/-   ##
==========================================
- Coverage   56.80%   56.78%   -0.02%     
==========================================
  Files          77       77              
  Lines       11947    11954       +7     
==========================================
+ Hits         6786     6788       +2     
- Misses       4666     4670       +4     
- Partials      495      496       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 force-pushed the tkappler/StaticSiteLinkedBackend-region branch from c06320c to 3f9d4d1 Compare December 9, 2024 11:27
@thomas11 thomas11 marked this pull request as ready for review December 9, 2024 11:27
@thomas11 thomas11 enabled auto-merge (squash) December 9, 2024 11:27
@thomas11 thomas11 merged commit d281a2b into master Dec 9, 2024
@thomas11 thomas11 deleted the tkappler/StaticSiteLinkedBackend-region branch December 9, 2024 12:01
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.77.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static Site Linked Backend creation fails with HTTP 500 error when not specifiying the region

3 participants