Fix cleaning of the .make directory#3727
Merged
Merged
Conversation
thomas11
approved these changes
Nov 21, 2024
thomas11
left a comment
Contributor
There was a problem hiding this comment.
two-char PRs are the best
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3727 +/- ##
=======================================
Coverage 56.41% 56.41%
=======================================
Files 74 74
Lines 11813 11813
=======================================
Hits 6664 6664
Misses 4652 4652
Partials 497 497 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Contributor
Author
And yet still causing a CI failure 🤔 |
Don't delete the directory, only the files inside it so that you can run clean followed by another command without it breaking. Fixes #3724
a11e916 to
d11279f
Compare
Contributor
Author
|
Seeing if this is fixed by changing the commit hash. It might be that Go gets confused when the short hash has no characters, only numbers, and begins with a zero. |
Contributor
|
This PR has been shipped in release v2.74.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't delete the directory, only the files inside it so that you can run clean followed by another command without it breaking.
Fixes #3724