Skip to content

Fix cleaning of the .make directory#3727

Merged
danielrbradley merged 1 commit into
masterfrom
fix-clean-make-dir
Nov 21, 2024
Merged

Fix cleaning of the .make directory#3727
danielrbradley merged 1 commit into
masterfrom
fix-clean-make-dir

Conversation

@danielrbradley

Copy link
Copy Markdown
Contributor

Don't delete the directory, only the files inside it so that you can run clean followed by another command without it breaking.

Fixes #3724

@danielrbradley danielrbradley self-assigned this Nov 21, 2024

@thomas11 thomas11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two-char PRs are the best

@github-actions

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@danielrbradley danielrbradley enabled auto-merge (squash) November 21, 2024 14:06
@codecov

codecov Bot commented Nov 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.41%. Comparing base (9003fb4) to head (d11279f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3727   +/-   ##
=======================================
  Coverage   56.41%   56.41%           
=======================================
  Files          74       74           
  Lines       11813    11813           
=======================================
  Hits         6664     6664           
  Misses       4652     4652           
  Partials      497      497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@danielrbradley

Copy link
Copy Markdown
Contributor Author

two-char PRs are the best

And yet still causing a CI failure 🤔

Don't delete the directory, only the files inside it so that you can run clean followed by another command without it breaking.

Fixes #3724
@danielrbradley

Copy link
Copy Markdown
Contributor Author

Seeing if this is fixed by changing the commit hash. It might be that Go gets confused when the short hash has no characters, only numbers, and begins with a zero.

@danielrbradley danielrbradley merged commit fd3945c into master Nov 21, 2024
@danielrbradley danielrbradley deleted the fix-clean-make-dir branch November 21, 2024 16:10
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.74.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make clean some_other_target fails because the .make folder is missing

3 participants