Skip to content

azcore fix: POST responses can be any type#3721

Merged
thomas11 merged 2 commits into
masterfrom
tkappler/post-primitive-response
Nov 21, 2024
Merged

azcore fix: POST responses can be any type#3721
thomas11 merged 2 commits into
masterfrom
tkappler/post-primitive-response

Conversation

@thomas11

@thomas11 thomas11 commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

Fixes #3716. In the autorest client, POST responses were unmarshaled into any, which allows for primitive types as well as objects. In the new azcore client, they were unmarshaled into map[string]any, requiring the response to be an object.

@thomas11 thomas11 requested review from a team and danielrbradley November 20, 2024 19:28
@github-actions

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@danielrbradley danielrbradley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@thomas11 thomas11 force-pushed the tkappler/post-primitive-response branch from 24c0dd1 to 6613d8f Compare November 21, 2024 08:35
@codecov

codecov Bot commented Nov 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.41%. Comparing base (0e7c8ee) to head (6613d8f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3721   +/-   ##
=======================================
  Coverage   56.40%   56.41%           
=======================================
  Files          74       74           
  Lines       11811    11813    +2     
=======================================
+ Hits         6662     6664    +2     
  Misses       4652     4652           
  Partials      497      497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.73.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using azcore breaks app/getCustomDomainVerificationId

3 participants