Correctly handle blob MD5 sums in custom blob resource, need to be base64-encoded

[thomas11]

This was initially missed because the previously used Azure SDK in custom_storage.go, and the newer one used in custom_storage_azidentity.go, behave differently. The older SDK leaves the user-provided MD5 sum alone, so the user needs to provide it base64-encoded, as the integration test examples/static-website/index.ts does. The newer SDK, however, expects the MD5 sum as a raw byte array and does the base64-decoding internally. Providing an already encoded sum leads to double-encoding and an invalid sum being sent to Azure.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[danielrbradley]

Change looks good. Would be good to have an integration test for the blobs running ahead of merge at some point.

Options I can see here:

1. Assuming you've run the test locally, that should suffice for now.
2. We could also do a manual CI run for the branch to include all tests.
3. We could also unmark one of the integration tests with skipIfShort so it's always run.
4. Or we should introduce a merge queue so it only merges after the full integration test suite has run.

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.30%. Comparing base (5713385) to head (29dcfee).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...urces/customresources/custom_storage_azidentity.go	28.57%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3718      +/-   ##
==========================================
- Coverage   56.31%   56.30%   -0.02%     
==========================================
  Files          74       74              
  Lines       11735    11738       +3     
==========================================
  Hits         6609     6609              
- Misses       4635     4638       +3     
  Partials      491      491              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[thomas11]

Change looks good. Would be good to have an integration test for the blobs running ahead of merge at some point.

Options I can see here:

1. Assuming you've run the test locally, that should suffice for now.
2. We could also do a manual CI run for the branch to include all tests.
3. We could also unmark one of the integration tests with skipIfShort so it's always run.
4. Or we should introduce a merge queue so it only merges after the full integration test suite has run.

I ran the full test suite via gh workflow run acceptance-test.yml --ref tkappler/blob-md5, result here.

[pulumi-bot]

This PR has been shipped in release v2.73.0.