Skip to content

Add force replacement for SqlResourceSqlRoleAssignment#3711

Merged
thomas11 merged 2 commits into
masterfrom
tkappler/otahirs
Nov 18, 2024
Merged

Add force replacement for SqlResourceSqlRoleAssignment#3711
thomas11 merged 2 commits into
masterfrom
tkappler/otahirs

Conversation

@thomas11

Copy link
Copy Markdown
Contributor

Original PR by @otahirs, re-opened due to CI permission issues.

force replacement for documentdb.SqlResourceSqlRoleAssignment if principalId or scope changes

fixes #3701

error: Code="BadRequest" Message="Updating SQL Role Assignment Principal ID is not permitted. You may only update the associated Role Definition.\r\nActivityId: 8a163189-0c65-45c0-9969-d09f2047f41d, Microsoft.Azure.Documents.Common/2.14.0"

@github-actions

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov

codecov Bot commented Nov 18, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (443af1f) to head (5e47f61).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3711      +/-   ##
==========================================
- Coverage   58.65%   55.95%   -2.70%     
==========================================
  Files          73       73              
  Lines       11560    11560              
==========================================
- Hits         6780     6468     -312     
- Misses       4257     4615     +358     
+ Partials      523      477      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 enabled auto-merge (rebase) November 18, 2024 09:21
@thomas11 thomas11 merged commit d8390b4 into master Nov 18, 2024
@thomas11 thomas11 deleted the tkappler/otahirs branch November 18, 2024 09:22
@thomas11

Copy link
Copy Markdown
Contributor Author

Thank you for your contribution @otahirs !

@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.73.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change of principalId in documentdb:SqlResourceSqlRoleAssignment fails to update resource

4 participants