Leverage az provider list by danielrbradley · Pull Request #3707 · pulumi/pulumi-azure-native

danielrbradley · 2024-11-15T20:02:41Z

Fixes #2661

Add inactive default versions report - which versions referenced from our default version are not currently marked as "live" by az provider list?
When picking a new tracking version, select from the live versions only, if any are live. Fall back to all versions if az provider list doesn't include any.
When checking for additional resources not in the default version, don't add new non-live versions.
Move most unit testing into gen_calculateVersionMetadata_test from defaultVersion_test as it's as close to e2e as possible and requires less mocking.

github-actions · 2024-11-15T20:07:56Z

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

codecov · 2024-11-15T20:17:34Z

Codecov Report

Attention: Patch coverage is 84.61538% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.80%. Comparing base (292977d) to head (50c3df9).
Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
provider/pkg/versioning/defaultVersion.go	92.15%	4 Missing ⚠️
provider/pkg/providerlist/providerlist.go	83.33%	3 Missing ⚠️
provider/pkg/versioning/build_schema.go	0.00%	2 Missing ⚠️
provider/pkg/versioning/gen.go	66.66%	2 Missing ⚠️
provider/cmd/pulumi-gen-azure-native/main.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3707      +/-   ##
==========================================
+ Coverage   56.41%   56.80%   +0.38%     
==========================================
  Files          74       74              
  Lines       11813    11838      +25     
==========================================
+ Hits         6664     6724      +60     
+ Misses       4652     4619      -33     
+ Partials      497      495       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thomas11

LGTM with some docs wishlist items

- Use built-in `--query` option instead of needing jq installed. - Move into `versions` directory where all other version data is. - Add `defaultVersion` and `locations` fields for each resourceType.

Use existing openapi.ApiVersionToDate function

- Add new report highlighting which versions in the default lock are not listed as live. - Remove old active report which was the same data as the 'az provider list' but reformatted. - Pass indexedProviderList into BuildSpec function.

- Fall back to any version if none are live. - Add documentation comments. - Create providerSpecBuilder class to give access to global, immutable data across functions to avoid passing providerName and providerList everywhere. - Simplify filtering candidate versions. Test adding resources only if they're live

- If the resource is already added, don't remove it. - If it's a new addition, but not yet live, don't add it.

- Test prefering live versions for tracking - Combine default version tests - Move lots of default version tests into the new calculateVersionMetadata tests which are a broader test and require less mocking.

pulumi-bot · 2024-12-06T16:32:33Z

This PR has been shipped in release v2.76.0.

danielrbradley self-assigned this Nov 15, 2024

danielrbradley temporarily deployed to env-ci November 15, 2024 20:24 — with GitHub Actions Inactive

danielrbradley force-pushed the leverage-az-provider-list branch from 2081bb3 to e3086cc Compare November 19, 2024 11:56

danielrbradley temporarily deployed to env-ci November 19, 2024 12:18 — with GitHub Actions Inactive

danielrbradley force-pushed the leverage-az-provider-list branch from d02d06d to f317565 Compare November 25, 2024 11:33

danielrbradley temporarily deployed to env-ci November 25, 2024 11:54 — with GitHub Actions Inactive

danielrbradley temporarily deployed to env-ci November 25, 2024 17:18 — with GitHub Actions Inactive

danielrbradley force-pushed the leverage-az-provider-list branch from cdde558 to 33452f9 Compare November 25, 2024 21:35

danielrbradley temporarily deployed to env-ci November 25, 2024 21:56 — with GitHub Actions Inactive

danielrbradley temporarily deployed to env-ci December 2, 2024 14:41 — with GitHub Actions Inactive

thomas11 approved these changes Dec 2, 2024

View reviewed changes

Comment thread Makefile

Comment thread provider/pkg/providerlist/providerlist.go

danielrbradley added 7 commits December 2, 2024 17:23

Move and refine 'az provider list' result

a6f688f

- Use built-in `--query` option instead of needing jq installed. - Move into `versions` directory where all other version data is. - Add `defaultVersion` and `locations` fields for each resourceType.

Simplify sorted versions

8f71c13

Simplify isMoreThanOneYearOld

39a7aac

Use existing openapi.ApiVersionToDate function

Load 'az provider list' for use in versioning

8b19a4d

- Add new report highlighting which versions in the default lock are not listed as live. - Remove old active report which was the same data as the 'az provider list' but reformatted. - Pass indexedProviderList into BuildSpec function.

Only add extra resources if live

b676487

- If the resource is already added, don't remove it. - If it's a new addition, but not yet live, don't add it.

Move and extend unit tests

50c3df9

- Test prefering live versions for tracking - Combine default version tests - Move lots of default version tests into the new calculateVersionMetadata tests which are a broader test and require less mocking.

danielrbradley force-pushed the leverage-az-provider-list branch from 1e65c4e to 50c3df9 Compare December 2, 2024 17:29

danielrbradley enabled auto-merge December 2, 2024 17:30

danielrbradley temporarily deployed to env-ci December 2, 2024 17:51 — with GitHub Actions Inactive

danielrbradley merged commit ee72d75 into master Dec 2, 2024

danielrbradley deleted the leverage-az-provider-list branch December 2, 2024 18:00

pulumi-bot mentioned this pull request Dec 6, 2024

Use the Azure RP API when determining default API versions #2661

Closed

dependabot Bot mentioned this pull request Aug 18, 2025

Bump Pulumi and Pulumi.AzureNative merca/data-and-stuff#118

Closed

dependabot Bot mentioned this pull request Aug 25, 2025

Bump Pulumi and Pulumi.AzureNative merca/data-and-stuff#123

Closed

This was referenced Sep 1, 2025

Bump Pulumi and Pulumi.AzureNative merca/data-and-stuff#130

Closed

Bump Pulumi and Pulumi.AzureNative merca/data-and-stuff#138

Closed

dependabot Bot mentioned this pull request Sep 15, 2025

Bump Pulumi and Pulumi.AzureNative merca/data-and-stuff#145

Closed

dependabot Bot mentioned this pull request Sep 22, 2025

Bump Pulumi and Pulumi.AzureNative merca/data-and-stuff#152

Closed

dependabot Bot mentioned this pull request Feb 2, 2026

Bump Pulumi and Pulumi.AzureNative merca/data-and-stuff#213

Closed

dependabot Bot mentioned this pull request Mar 2, 2026

Bump Pulumi and Pulumi.AzureNative merca/data-and-stuff#220

Closed

dependabot Bot mentioned this pull request Mar 9, 2026

Bump Pulumi and Pulumi.AzureNative merca/data-and-stuff#221

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leverage az provider list#3707

Leverage az provider list#3707
danielrbradley merged 8 commits into
masterfrom
leverage-az-provider-list

danielrbradley commented Nov 15, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 15, 2024

Uh oh!

codecov Bot commented Nov 15, 2024 •

edited

Loading

Uh oh!

thomas11 left a comment

Uh oh!

Uh oh!

Uh oh!

pulumi-bot commented Dec 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

danielrbradley commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 15, 2024

Does the PR have any schema changes?

Uh oh!

codecov Bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thomas11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pulumi-bot commented Dec 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danielrbradley commented Nov 15, 2024 •

edited

Loading

codecov Bot commented Nov 15, 2024 •

edited

Loading