Skip to content

Migrate custom Key Vault resource to azidentity#3664

Merged
thomas11 merged 5 commits into
masterfrom
tkappler/kv-azidentity
Nov 5, 2024
Merged

Migrate custom Key Vault resource to azidentity#3664
thomas11 merged 5 commits into
masterfrom
tkappler/kv-azidentity

Conversation

@thomas11

@thomas11 thomas11 commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

This PR ended up having three distinct but related parts to it.

  1. Migrate the custom KV resource to the new azidentity backend. We need to preserve the previous one because it uses a special Autorest authorizer for Key Vault.
  2. Use a Key Vault secret in the azure-in-azure integration test. KV secrets need a different authentication audience/scope in the access token and we want to cover this case.
  3. A fix that affects master as well: the azure-in-azure test didn't use the correct environment variable for the new backend toggle.

Green run of the azcore workflow using the new backend

Fixes #2432

@github-actions

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov

codecov Bot commented Oct 23, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 37.87879% with 41 lines in your changes missing coverage. Please review.

Project coverage is 57.28%. Comparing base (7060a50) to head (190ff02).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ources/customresources/custom_keyvault_autorest.go 17.14% 27 Missing and 2 partials ⚠️
...r/pkg/resources/customresources/custom_keyvault.go 15.38% 11 Missing ⚠️
provider/pkg/provider/provider.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3664      +/-   ##
==========================================
- Coverage   57.43%   57.28%   -0.15%     
==========================================
  Files          70       72       +2     
  Lines       11131    11180      +49     
==========================================
+ Hits         6393     6405      +12     
- Misses       4257     4292      +35     
- Partials      481      483       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 force-pushed the tkappler/kv-azidentity branch from b45a6a7 to 7c2133c Compare November 4, 2024 07:36
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.70.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid audience for Key Vault secret operations when using MSI

3 participants