Skip to content

Disambiguate conflicting NotificationConfiguration types in AwsConnector#3658

Merged
thomas11 merged 2 commits into
masterfrom
tkappler/awsconnector-3657
Oct 22, 2024
Merged

Disambiguate conflicting NotificationConfiguration types in AwsConnector#3658
thomas11 merged 2 commits into
masterfrom
tkappler/awsconnector-3657

Conversation

@thomas11

@thomas11 thomas11 commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

Fixes #3657

The new AwsConnector RP schema added several types called NotificationConfiguration that are different.

Question to ourselves: we should be able to detect that they're incompatible, what's missing here?

@thomas11 thomas11 requested review from a team and danielrbradley October 21, 2024 14:44
@github-actions

github-actions Bot commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Found 14 breaking changes:

Types

  • "azure-native:awsconnector:AwsAutoScalingAutoScalingGroupProperties": properties:
    • 🟡 "notificationConfiguration" type changed from "#/types/azure-native:awsconnector:NotificationConfiguration" to "#/types/azure-native:awsconnector:AutoScalingGroupNotificationConfiguration"
    • 🟡 "notificationConfigurations": items type changed from "#/types/azure-native:awsconnector:NotificationConfiguration" to "#/types/azure-native:awsconnector:AutoScalingGroupNotificationConfiguration"
  • "azure-native:awsconnector:AwsAutoScalingAutoScalingGroupPropertiesResponse": properties:
    • 🟡 "notificationConfiguration" type changed from "#/types/azure-native:awsconnector:NotificationConfigurationResponse" to "#/types/azure-native:awsconnector:AutoScalingGroupNotificationConfigurationResponse"
    • 🟡 "notificationConfigurations": items type changed from "#/types/azure-native:awsconnector:NotificationConfigurationResponse" to "#/types/azure-native:awsconnector:AutoScalingGroupNotificationConfigurationResponse"
  • 🟡 "azure-native:awsconnector:AwsDaxClusterProperties": properties: "notificationConfiguration" type changed from "#/types/azure-native:awsconnector:NotificationConfiguration" to "#/types/azure-native:awsconnector:DaxClusterNotificationConfiguration"
  • 🟡 "azure-native:awsconnector:AwsDaxClusterPropertiesResponse": properties: "notificationConfiguration" type changed from "#/types/azure-native:awsconnector:NotificationConfigurationResponse" to "#/types/azure-native:awsconnector:DaxClusterNotificationConfigurationResponse"
  • "azure-native:awsconnector:NotificationConfiguration": properties:
    • 🟡 "notificationTypes" missing
    • 🟡 "topicARN" missing
    • 🟡 "topicArn" missing
    • 🟡 "topicStatus" missing
  • "azure-native:awsconnector:NotificationConfigurationResponse": properties:
    • 🟡 "notificationTypes" missing
    • 🟡 "topicARN" missing
    • 🟡 "topicArn" missing
    • 🟡 "topicStatus" missing
      No new resources/functions.

@codecov

codecov Bot commented Oct 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.82%. Comparing base (44ec792) to head (6151055).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3658   +/-   ##
=======================================
  Coverage   59.82%   59.82%           
=======================================
  Files          67       67           
  Lines       10667    10667           
=======================================
  Hits         6381     6381           
  Misses       3794     3794           
  Partials      492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 force-pushed the tkappler/awsconnector-3657 branch from 3ddff9d to 2dac6ba Compare October 21, 2024 20:54
@thomas11 thomas11 force-pushed the tkappler/awsconnector-3657 branch from 2dac6ba to 6151055 Compare October 22, 2024 15:54
@thomas11 thomas11 merged commit 83d511e into master Oct 22, 2024
@thomas11 thomas11 deleted the tkappler/awsconnector-3657 branch October 22, 2024 16:44
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.68.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax error in Python SDK AwsConnector

3 participants