Skip to content

Unblock SDK gen with required properties edits#3600

Merged
thomas11 merged 3 commits into
masterfrom
tkappler/required-properties-do-not-match
Sep 30, 2024
Merged

Unblock SDK gen with required properties edits#3600
thomas11 merged 3 commits into
masterfrom
tkappler/required-properties-do-not-match

Conversation

@thomas11

Copy link
Copy Markdown
Contributor
  • Add two more required property edits for conflicting types
  • Update spec and regenerate
  • Add section to playbook for this kind of conflict

Fixes #3598

@thomas11 thomas11 requested review from a team and danielrbradley September 30, 2024 08:19
@github-actions

github-actions Bot commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Found 6 breaking changes:

Types

  • "azure-native:containerinstance:Container": required:
    • 🟢 "image" property is no longer Required
    • 🟢 "resources" property is no longer Required
  • "azure-native:containerinstance:ContainerResponse": required:
    • 🟢 "image" property is no longer Required
    • 🟢 "resources" property is no longer Required
  • 🟢 "azure-native:datafactory:PostgreSqlV2LinkedService": required: "authenticationType" property has changed to Required
  • 🟢 "azure-native:datafactory:PostgreSqlV2LinkedServiceResponse": required: "authenticationType" property has changed to Required

New resources:

  • containerinstance.ContainerGroupProfile
  • network.DnsResolverDomainList
  • network.DnsResolverPolicy
  • network.DnsResolverPolicyVirtualNetworkLink
  • network.DnsSecurityRule
  • securityinsights.BusinessApplicationAgent
  • securityinsights.System

New functions:

  • containerinstance.getContainerGroupProfile
  • network.getDnsResolverDomainList
  • network.getDnsResolverPolicy
  • network.getDnsResolverPolicyVirtualNetworkLink
  • network.getDnsSecurityRule
  • network.listDnsResolverPolicyByVirtualNetwork
  • securityinsights.getBusinessApplicationAgent
  • securityinsights.getSystem
  • securityinsights.listSystemActions

@danielrbradley danielrbradley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type conflict looks okay to just remove the required properties from 👍

The alternative approach here would have been to exclude the new version of network from the current default version so they'd only be available via the explicit version until the next major release - which then avoids the conflict altogether.

@thomas11 thomas11 force-pushed the tkappler/required-properties-do-not-match branch from f9450d2 to 43afaef Compare September 30, 2024 08:30
@codecov

codecov Bot commented Sep 30, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.95%. Comparing base (cf9de59) to head (43afaef).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/gen/types.go 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3600      +/-   ##
==========================================
- Coverage   58.98%   58.95%   -0.04%     
==========================================
  Files          68       68              
  Lines        8658     8663       +5     
==========================================
  Hits         5107     5107              
- Misses       3081     3085       +4     
- Partials      470      471       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 merged commit 1bd7037 into master Sep 30, 2024
@thomas11 thomas11 deleted the tkappler/required-properties-do-not-match branch September 30, 2024 09:10
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.64.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow failure: nightly-sdk-generation

3 participants