Unblock SDK gen with required properties edits#3600
Merged
Conversation
Contributor
Does the PR have any schema changes?Found 6 breaking changes: Types
New resources:
New functions:
|
danielrbradley
approved these changes
Sep 30, 2024
danielrbradley
left a comment
Contributor
There was a problem hiding this comment.
This type conflict looks okay to just remove the required properties from 👍
The alternative approach here would have been to exclude the new version of network from the current default version so they'd only be available via the explicit version until the next major release - which then avoids the conflict altogether.
f9450d2 to
43afaef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3600 +/- ##
==========================================
- Coverage 58.98% 58.95% -0.04%
==========================================
Files 68 68
Lines 8658 8663 +5
==========================================
Hits 5107 5107
- Misses 3081 3085 +4
- Partials 470 471 +1 ☔ View full report in Codecov by Sentry. |
Contributor
|
This PR has been shipped in release v2.64.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3598