Support DefenderForStorageSettings resource by adding default state#3007
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3007 +/- ##
=======================================
Coverage 60.64% 60.65%
=======================================
Files 66 66
Lines 11019 11027 +8
=======================================
+ Hits 6683 6688 +5
- Misses 3788 3790 +2
- Partials 548 549 +1 ☔ View full report in Codecov by Sentry. |
This is backwards-compatible because this PR introduces this resource.
d6f0a71 to
1fc6706
Compare
danielrbradley
approved these changes
Jan 24, 2024
danielrbradley
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Does your other PR have a note so we remember to remove this when it merges?
Contributor
Author
Added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support DefenderForStorageSettings resource by adding the default state to reset it to on delete, since it doesn't have an actual delete operation.
Without the hard-coded exception in the last commit, the generated schema is incorrect. The cause is unrelated to the PR. What's happening is that the Azure spec is defined as such (unrelated properties omitted):
Where SensitiveDataDiscoveryProperties is:
The nested object is annotated with x-ms-client-flatten, causing the object to be flattened, causing the two identical
isEnabledproperties to collide. #3016 will fix this in v3.In the meantime, I added a manual exception.
Resolves #2996