Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake example #1481

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jkodroff
Copy link
Member

No description provided.

@pulumi-staging
Copy link

🍹 The Update for moolumi/k8s-ci-cluster/580e8ba665bc506ee07a2a6fd0550f80218efe5d-1493 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-580e8ba665bc506ee07a2a6fd0550f80218efe5d-1493  pulumi:pulumi:Stack                         create

@pulumi-staging
Copy link

🍹 The Destroy for moolumi/k8s-ci-cluster/580e8ba665bc506ee07a2a6fd0550f80218efe5d-1493 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete

@jkodroff jkodroff requested a review from sicarul August 23, 2023 18:01
Copy link
Member

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a couple lil' things need fixing up, but otherwise looks great!

name: python
options:
virtualenv: venv
description: A minimal Python Pulumi program
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be something like "An example of exporting Pulumi Cloud data to Snowflake"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should.

role=lambda_role.arn,
runtime="python3.8",
handler="handler.handle",
code=pulumi.FileArchive('./.build'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fail on pulumi up:

Exception: failed to compute archive hash for "code": couldn't read archive path './.build': stat ./.build: no such file or directory

Should it be this?

Suggested change
code=pulumi.FileArchive('./.build'),
code=pulumi.FileArchive('./search_export_to_s3'),

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagnosis is correct, but the issue is that .build/ is not properly created in all environments. The Lambda code has to be staged in .build/ because of how Python Lambdas are packaged. Will fix.

# NOTE: In a production scenario, for security reasons this should should call
# `config.require_secret()`, use a Pulumi access token specifically designated
# for this export process, and not fall back to an environment variable:
pulumi_access_token = config.get_secret(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview fails without a PULUMI_ACCESS_TOKEN. Should we document this in the README as a pre-req?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Will fix.

@cnunciato cnunciato self-assigned this Aug 24, 2023
@cnunciato cnunciato added the size/S Estimated effort to complete (1-2 days). label Aug 24, 2023
@cnunciato cnunciato added this to the 0.93 milestone Aug 24, 2023
@jkodroff
Copy link
Member Author

jkodroff commented Sep 4, 2023

We're probably changing the approach for the Snowflake blog post b/c Pulumi Cloud data export is an Enterprise+ and is not easy to seed with data. I'll come back and finish this PR once we have the code that will be used in the blog post finished.

@scottslowe scottslowe modified the milestones: 0.93, 0.94 Sep 7, 2023
@scottslowe
Copy link
Contributor

@jkodroff I've bumped this from 0.93 to 0.94. If you don't think you'll wrap it up in this sprint, then feel free to adjust the milestone accordingly. Thanks!

@mikhailshilkov mikhailshilkov removed this from the 0.94 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants