fix action link in slack alert #8540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your site preview for commit 5648103 is ready! 🎉 http://pulumi-docs-origin-pr-8540-56481039.s3-website.us-west-2.amazonaws.com. |
zchase
approved these changes
Feb 3, 2023
|
Site previews for this pull request have been removed. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug with the github action that is being used and there has been a PR open in that repo for a few weeks to fix it and looks like the action maintainer has not gotten around to addressing it. I went and forked the repo and applied the fix. I then rebuilt the action's docker image and published a new docker image with the fix for this to use. This PR just updates the action to reference the new docker image I published with the fix. We switch back to using the "official" action once they get around to addressing that PR.
The problem was that the action was coded to reference the workflow by a specific commit. The issue with that, is that often times when things are merged to master or pulled in from upstream, it kicks off multiple workflows that run against that same commit, so the link that was there did not know specifically which workflow failed, it only knew the commit sha it failed at. This fix now links to the specific workflow run that failed from that commit.
Here is a before and after of the URL that was being linked to:
before fix:
https://github.com/pulumi/docs/commit/b299b33f5a6277493020174e552c14ffd17bdc1c/checks
after fix
https://github.com/pulumi/docs/actions/runs/4087423781/attempts/1
This should resolve the issue now that we are referencing the specific run, though we won't know for real until it actually gets used in real life.