Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter deprecated APIs in Node.js docs #1779

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Conversation

justinvp
Copy link
Member

  • Instead, keep them with a "deprecated" note.
  • Regenerate the docs (including updated docs for @pulumi/kubernetes v1.1.0 which has new deprecations.

Screen Shot 2019-09-24 at 8 01 25 AM

(Note: The brackets around other types/members in deprecated messages will be turned into real links with #1528.)

Fixes #1766

@github-actions
Copy link

Your site preview for commit b3fd14f is now available! 🍹

http://content-bucket-a5ad76e.s3-website-us-east-1.amazonaws.com

Deploy previews powered by Pulumify

Copy link

@pulumi pulumi bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.

Resource Changes

    Name                                                                                       Type                              Operation
~   blog/author/chris-smith/index.html                                                         aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_datadog/pagerduty/index.html                              aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_kubernetes/admissionregistration/index.html               aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_kubernetes/scheduling/v1alpha1/index.html                 aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/digitalocean/types/index.html                             aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/docker/types/index.html                                   aws:s3/bucketObject:BucketObject  update
~   docs/get-started/aws/install-language-runtime/index.html                                   aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/kubernetes/settings/v1alpha1/index.html                   aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/azuread/types/output/index.html                           aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_aws/inspector/index.html                                  aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/gcp/appengine/index.html                                  aws:s3/bucketObject:BucketObject  update
~   blog/data-science-on-demand-spinning-up-a-wallaroo-cluster-is-easy-with-pulumi/index.html  aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/kubernetes/types/index.html                               aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_gcp/service_account/index.html                            aws:s3/bucketObject:BucketObject  update
~   docs/tutorials/aws/aws-ts-url-shortener-cache-http/index.html                              aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/awsx/cloudwatch/index.html                                aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/azure/management/index.html                               aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_azure/logicapps/index.html                                aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_gcp/firestore/index.html                                  aws:s3/bucketObject:BucketObject  update
~   docs/get-started/aws/deploy-stack/index.html                                               aws:s3/bucketObject:BucketObject  update
~   blog/tag/aws/page/3/index.html                                                             aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_gcp/dns/index.html                                        aws:s3/bucketObject:BucketObject  update
~   docs/tutorials/aws/aws-js-s3-folder/index.html                                             aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/kubernetes/authorization/index.html                       aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_gcp/tpu/index.html                                        aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/gcp/iap/index.html                                        aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/azure/network/index.html                                  aws:s3/bucketObject:BucketObject  update
~   blog/welcoming-gitlab-users-to-pulumi/index.html                                           aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/azure/appinsights/index.html                              aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/azure/hdinsight/index.html                                aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_gcp/resourcemanager/index.html                            aws:s3/bucketObject:BucketObject  update
~   blog/easy-serverless-apps-and-infrastructure-real-events-real-code/index.html              aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/aws/ec2clientvpn/index.html                               aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_kubernetes/helm/v2/index.html                             aws:s3/bucketObject:BucketObject  update
~   docs/reference/cli/index.html                                                              aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_openstack/vpnaas/index.html                               aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/kubernetes/batch/index.html                               aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_kubernetes/certificates/v1beta1/index.html                aws:s3/bucketObject:BucketObject  update
~   docs/reference/cli/pulumi_preview/index.html                                               aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/azure/monitoring/index.html                               aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/kubernetes/types/input/index.html                         aws:s3/bucketObject:BucketObject  update
... and 1216 other changes

Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes changes LGTM

Instead, keep them with a "deprecated" note about.
@github-actions
Copy link

Your site preview for commit fb232c2 is now available! 🍹

http://content-bucket-a5ad76e.s3-website-us-east-1.amazonaws.com

Deploy previews powered by Pulumify

Copy link

@pulumi pulumi bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.

Resource Changes

    Name                                                                                          Type                              Operation
~   docs/reference/pkg/nodejs/pulumi/aws/pinpoint/index.html                                      aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/aws/xray/index.html                                          aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/gcp/storage/index.html                                       aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_aws/macie/index.html                                         aws:s3/bucketObject:BucketObject  update
~   docs/get-started/kubernetes/modify-program/index.html                                         aws:s3/bucketObject:BucketObject  update
~   docs/guides/crosswalk/aws/ecr/index.html                                                      aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/aws/iot/index.html                                           aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/kubernetes/scheduling/v1alpha1/index.html                    aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_gcp/filestore/index.html                                     aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/azure/appservice/index.html                                  aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/packet/types/index.html                                      aws:s3/bucketObject:BucketObject  update
~   docs/tutorials/gcp/index.html                                                                 aws:s3/bucketObject:BucketObject  update
~   blog/pulumi-now-supports-atlassian-identity/index.html                                        aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/openstack/objectstorage/index.html                           aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_kubernetes/yaml/index.html                                   aws:s3/bucketObject:BucketObject  update
~   docs/reference/cli/pulumi/index.html                                                          aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/kubernetes/authorization/v1beta1/index.html                  aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_kubernetes/core/index.html                                   aws:s3/bucketObject:BucketObject  update
~   blog/author/eric-rudder/index.html                                                            aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_aws/ssm/index.html                                           aws:s3/bucketObject:BucketObject  update
~   docs/get-started/azure/deploy-stack/index.html                                                aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/aws/dms/index.html                                           aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/aws/index.html                                               aws:s3/bucketObject:BucketObject  update
~   blog/day-2-kubernetes-migrating-eks-nodegroups-with-zero-downtime/index.html                  aws:s3/bucketObject:BucketObject  update
~   blog/persisting-kubernetes-workloads-with-amazon-efscsi-volumes-using-pulumi-sdks/index.html  aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/azure/ddosprotection/index.html                              aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_gcp/iam/index.html                                           aws:s3/bucketObject:BucketObject  update
~   docs/get-started/azure/create-project/index.html                                              aws:s3/bucketObject:BucketObject  update
~   docs/tutorials/aws/aws-ts-slackbot/index.html                                                 aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/gcp/serviceaccount/index.html                                aws:s3/bucketObject:BucketObject  update
~   docs/tutorials/azure/azure-js-webserver/index.html                                            aws:s3/bucketObject:BucketObject  update
~   blog/level-up-your-azure-platform-as-a-service-applications-with-pulumi/index.html            aws:s3/bucketObject:BucketObject  update
~   crosswalk/index.html                                                                          aws:s3/bucketObject:BucketObject  update
~   docs/get-started/aws/modify-program/index.html                                                aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/terraform/index.html                                         aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/gcp/pubsub/index.html                                        aws:s3/bucketObject:BucketObject  update
~   docs/tutorials/kubernetes/p8s-rollout/index.html                                              aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_azure/analysisservices/index.html                            aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/python/pulumi_azure/network/index.html                                     aws:s3/bucketObject:BucketObject  update
~   docs/get-started/gcp/deploy-stack/index.html                                                  aws:s3/bucketObject:BucketObject  update
~   docs/reference/pkg/nodejs/pulumi/kubernetes/scheduling/v1/index.html                          aws:s3/bucketObject:BucketObject  update
... and 1220 other changes

@justinvp justinvp merged commit 0782ccb into master Sep 25, 2019
@pulumi-bot pulumi-bot deleted the justin/deprecated branch September 25, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not filter out APIs marked @deprecated from API docs
2 participants