Skip to content

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Mar 25, 2021

No description provided.

@stack72 stack72 changed the title Starting to build out the automation Adding the automation for the examples in this repo Mar 26, 2021
@stack72 stack72 requested a review from komalali March 26, 2021 17:28
@stack72 stack72 self-assigned this Mar 26, 2021
Copy link
Member

@komalali komalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be okay to take this as-is but I'm wondering if there's any way to cut down the repetition in ci.yml. Is putting some of those jobs in a matrix an option?

@stack72
Copy link
Contributor Author

stack72 commented Mar 26, 2021

I spoke with @komalali offline and we decided that it's fine for these not to be totally DRY for now but that we should round back on this later

@stack72 stack72 merged commit 46c1a17 into main Mar 26, 2021
@stack72 stack72 deleted the add-automation branch March 26, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants