Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Stop handling beta, nightly #922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/atom-environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -600,15 +600,15 @@ class AtomEnvironment {
// Public: Gets the release channel of the Pulsar application.
//
// Returns the release channel as a {String}. Will return a specific release channel
// name like 'beta' or 'nightly' if one is found in the Pulsar version or 'stable'
// name like 'dev' if one is found in the Pulsar version or 'stable'
// otherwise.
getReleaseChannel() {
return getReleaseChannel(this.getVersion());
}

// Public: Returns a {Boolean} that is `true` if the current version is an official release.
isReleasedVersion() {
return this.getReleaseChannel().match(/stable|beta|nightly/) != null;
return this.getReleaseChannel().match(/stable|dev/) != null;
}
Comment on lines 609 to 612
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno, you can build Pulsar locally without changing the version string in package.json from e.g. 1.113.0-dev. I don't generally think -dev versions are "Released Versions"... Right?


// Public: Get the time taken to completely load the current window.
Expand Down
8 changes: 3 additions & 5 deletions src/command-installer.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,12 @@ module.exports = class CommandInstaller {
}

getCommandNameForChannel(commandName) {
let channelMatch = this.appVersion.match(/beta|nightly/);
let channelMatch = this.appVersion.match(/dev/);
let channel = channelMatch ? channelMatch[0] : '';

switch (channel) {
case 'beta':
return `${commandName}-beta`;
case 'nightly':
return `${commandName}-nightly`;
case 'dev':
return `${commandName}-dev`;
default:
return commandName;
}
Comment on lines 47 to 56
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a situation where Pulsar can be launched with the CLI command name pulsar-dev?

Otherwise, I think we might just need to reduce this function's body to simply return commandName...

Expand Down
Loading