Remove aspects of tests not testing the cli #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently we can no longer assume that base_url is an url. But also this really is not testing CLI behaviour and should not be here in the first place.
mdellweg
commented
Jan 22, 2025
| # if base_url starts with "/" (relative path) we need to prepend it with the server address | ||
| if [[ $base_url == /* ]] | ||
| then | ||
| base_url="https://pulp:443${base_url}" |
There was a problem hiding this comment.
Hardcoding a server address in these tests was never going to work properly.
ggainey
approved these changes
Jan 27, 2025
Backport to 0.30: 💚 backport PR created✅ Backport PR branch: Backported as #1124 🤖 @patchback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we can no longer assume that base_url is an url. But also this really is not testing CLI behaviour and should not be here in the first place.