target: Fix testbench clock period regression from #168 #205
+20
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required cause an absolute path to `snitch_bootrom.sv` is used in the Make dependency list, while a relative path is used in a rule target. This would lead to a "No rule to make target" error when building the HW after a `make clean`.
colluca
requested review from
paulsc96,
lucabertaccini and
fischeti
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the testbench clock period back to 1ns from 10ns, after it was unadvertedly changed with #168.
This PR was split from #204, see discussion thereof for more details.