Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dma_core_wrap, idma_reg64_frontend: Minor fixes #15

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

Vyeow
Copy link

@Vyeow Vyeow commented Oct 27, 2022

In dma_core_wrap we encountered this error:
Error: src/systems/cva6_reg/dma_core_wrap.sv(60): 'burst_req_t' is an unknown type.
We believe that this was meant to be idma_req_t as this type was declared just before.

And in idma_reg64_frontend we encountered these warnings:

Warning: (vsim-3015) [PCDPC] - Port size (64) does not match connection size (48) for port 'next_o'. The port definition is at: src/frontends/idma_transfer_id_gen.sv(19).
File: src/frontends/register_64bit/idma_reg64_frontend.sv Line: 143

Warning: (vsim-3015) [PCDPC] - Port size (64) does not match connection size (48) for port 'completed_o'. The port definition is at: src/frontends/idma_transfer_id_gen.sv(21).
File: src/frontends/register_64bit/idma_reg64_frontend.sv Line: 143

The signals next_id, done_id are declared with length DmaAddrWidth instead of DmaRegisterWidth. We believe that this is unintentional, as the config registers are 64 bits wide.
However, note that with this fix the parameter DmaAddrWidth will not be used anywhere in the module.

@Vyeow Vyeow requested a review from thommythomaso October 27, 2022 18:50
@Vyeow Vyeow requested a review from micprog as a code owner October 27, 2022 18:50
Copy link
Collaborator

@thommythomaso thommythomaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will remove the parameter and merge.

@thommythomaso thommythomaso merged commit 4aa2ef7 into master Oct 28, 2022
@thommythomaso thommythomaso deleted the fix/core_wrap branch October 28, 2022 09:03
@thommythomaso thommythomaso temporarily deployed to github-pages October 28, 2022 09:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants