Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KUL Cluster SW regression test #36

Open
wants to merge 2 commits into
base: scheremo/convolveIntegration
Choose a base branch
from

Conversation

xiaoling-yi
Copy link

@xiaoling-yi xiaoling-yi commented Aug 29, 2024

In this PR, we add the software test for the KUL cluster. More specifically, we add:

  • sw/tests/kulClusterOffload.c which is the main test to offload the test function kul_cluster_sw_test() to KUL cluster

  • sw/kul-cluster-test/src/snax-kul-cluster-TO-test.c which contains the entry of the test function kul_cluster_sw_test()

  • sw/kul-cluster-test/data/data.h which contains the test-related data

  • sw/kul-cluster-test/include/* contains header files that need to be added in the include path for compiling the kul_cluster_sw_test()

  • sw/kul-cluster-test/lib/* contains two libraries (snax-gemmx-lib and snax-data-reshuffler-lib) that need to be compiled and likned before compiling kul_cluster_sw_test(). To compile these two libraries, include/snrt_TO.h is needed.

@xiaoling-yi xiaoling-yi marked this pull request as draft August 29, 2024 18:30
@Scheremo
Copy link
Collaborator

Scheremo commented Sep 4, 2024

Hi Xiaoling,
Thanks for your contribution! I have a few questions before going further in-depth with reviewing.

  1. I see you use the DMA in some circumstances. Would it be possible to instead preload all your data in L1? This reduces turn around time by a lot.
  2. I didn't see you setting the stack pointer; does this test work on your end?

Best,
Moritz

@xiaoling-yi
Copy link
Author

Hi Moritz,

I see you use the DMA in some circumstances. Would it be possible to instead preload all your data in L1? This reduces turn around time by a lot.

What do you mean by preload data?
Is it putting all the DMA functions together at the beginning of the test function kul_cluster_sw_test?

I didn't see you setting the stack pointer; does this test work on your end?

I set the stack pointer just now to the end of the KUL cluster TCDM (size = 128KB) address. Is it the right way to set it before the offloadToCluster call?
Yes, I tested it on the snax cluster level but not the Chimera level yet.

Thanks!

Best regards,
Xiaoling

@Scheremo Scheremo force-pushed the scheremo/convolveIntegration branch 2 times, most recently from c69deaa to 10d087c Compare October 11, 2024 11:52
@xiaoling-yi xiaoling-yi marked this pull request as ready for review October 15, 2024 09:19
@Scheremo Scheremo force-pushed the scheremo/convolveIntegration branch from 178eed5 to b170c19 Compare October 23, 2024 08:31
@xiaoling-yi xiaoling-yi force-pushed the kul/add-sw-test branch 2 times, most recently from 41af047 to 5f1abbc Compare November 28, 2024 20:10
@Lore0599 Lore0599 force-pushed the scheremo/convolveIntegration branch from a73f571 to 85edc54 Compare December 3, 2024 13:13
@xiaoling-yi xiaoling-yi changed the title add kul sw test function Add KUL Cluster sw regression test function Dec 10, 2024
@xiaoling-yi
Copy link
Author

Hi Moritz!

The two snitch core is waked up through the host. This is the only way that I managed it to work.
Also the return value at the host level is a combination of the two workload test. As the two workloads both turn 0 from the snitch core and turned out 1 from the view of host (the bootrom did something: uint32_t retVal = ret | 0x000000001;). So the final return value is 10001.

Please free feel to modify them as you need.

Best regards,
Xiaoling

@xiaoling-yi xiaoling-yi changed the title Add KUL Cluster sw regression test function Add KUL Cluster sw regression test Dec 10, 2024
@xiaoling-yi xiaoling-yi changed the title Add KUL Cluster sw regression test Add KUL Cluster SW regression test Dec 10, 2024
@Lore0599 Lore0599 force-pushed the scheremo/convolveIntegration branch 3 times, most recently from 7ef8cfa to d04d8a4 Compare January 25, 2025 15:35
@Lore0599 Lore0599 force-pushed the scheremo/convolveIntegration branch from 7848d03 to 2de4164 Compare January 27, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants