Bug fix/issue 17 #24
Merged
Bug fix/issue 17 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Sebi1128
commented
Dec 16, 2024
Sebi1128
commented
- Replaced R1, R5, R6, R8, R9, R10, R11, R13 with 0.1Ohm, 250mW resistors
- Placed a weak pull-down resistor to fix the disabled state of TLV62569 by default
- Replaced R1, R5, R6, R8, R9, R10, R11, R13 with 0.1Ohm, 250mW resistors - Placed a weak pull-down resistor to fix the disabled state of TLV62569 by default
Sergio5714
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Hello Sebastian! Thank you for addressing the issues #17. I reviewed the source design files and all the generated files (schematic pdf sheets, assembly, BOM lists, etc)
The only missing part is an update in the CHANGELOG.md files. Could you please document your changes? Then, I will be happy to approve the pull request.
Sergio5714
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.