Adds args string_list option to proto_compile

[pcj]

• Also makes the langs attribute non-mandatory.

Closes #57

[pcj]

@perezd Does this LGTY?

[perezd]

Looks great! Thank you for turning this around so fast.

[perezd]

Interesting second observation, using this approach, I don't believe I can have proto A depend on proto B and have them both appear in a descriptor_set. Can I specify proto_deps in proto_compile in some way?

EDIT: Oh wait, spoke too soon, I think the deps attr works OK for this actually.

[perezd]

Another thing I'm noticing, there is no way to reference well known protos via only proto_compile, is there? That is a filegroup of protos listed at @com_github_google_protobuf//:well_known_protos...Is there a way to get these in the right place?

[pcj]

I updated the example for well_known_protos. WDYT?

[perezd]

So that does appear to work, but it feels awkward. I would press forward with this, but I will probably just wrap that in a macro def to reduce the noise at call sites.

Larger more strategic question: maybe we should consider making proto_descriptor_set_out a "proto language" rule? Its described as effectively an output target anyhow like java/cpp/etc.:
https://developers.google.com/protocol-buffers/docs/techniques#self-description

WDYT?

[pcj]

So what would that look like? Something like...?

proto_language(
    name = "descriptor",
    args = [
         "--include_imports",
         "--include_source_info",
     ],
     pb_imports = ["external/com_github_google_protobuf/src"],
     pb_inputs = ["@com_github_google_protobuf//:well_known_protos"],
)

descriptor_proto_library(
  name = "api",
  protos = [...],
)

[perezd]

Yeah I think that makes the most sense. The output of that would be api.pb.descriptor. Although, I would still prefer "srcs" over "protos" 😄

[pcj]

@perezd Merged this and created separate issue for descriptor language issue #62.

[perezd]

Awesome, thank you for this!

…

On Mon, Jan 30, 2017 at 10:24 PM Paul Cody Johnston < ***@***.***> wrote: @perezd <https://github.com/perezd> Merged this and created separate issue for descriptor language issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#58 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABQdgx4PpPruhuSuirK2l3X44oWq9Lqks5rXtOdgaJpZM4LqGWe> .