Refactor question card #9922
Refactor question card #9922
Conversation
|
|
| <p class="meta"><%= render partial: "dashboard/node_meta", locals: { node: node } %></p> | ||
| </div> | ||
| </div> | ||
| <%= render partial: 'notes/card', locals: { node: node, i: i, tagname: tagname } %> |
There was a problem hiding this comment.
This looks great. What do you think might be happening with the tests? The instance variable @widget should be persisted into the partial template. What are the logs saying?
Thanks!!
There was a problem hiding this comment.
I'm new here, first day, but I did see an error on the test run that may help.
undefined local variable or method tagname' for #<#<Class:0x000055de006c8e30>:0x000055de0460da78> app/views/questions/_questions.html.erb:5:in block in _app_views_questions__questions_html_erb__4321177480707985642_47206022398320'
app/views/questions/_questions.html.erb:3:in each_with_index' app/views/questions/_questions.html.erb:3:in _app_views_questions__questions_html_erb__4321177480707985642_47206022398320'
app/views/questions/index.html.erb:79:in _app_views_questions_index_html_erb__3421750489030126837_47206022279460' test/integration/login_flow_test.rb:58:in block in class:LoginFlowTest'
|
Code Climate has analyzed commit 27bbb25 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9922 +/- ##
==========================================
+ Coverage 82.14% 82.26% +0.11%
==========================================
Files 98 98
Lines 5960 5966 +6
==========================================
+ Hits 4896 4908 +12
+ Misses 1064 1058 -6
|
|
Hi @jywarren I think this is good to go now! |
|
Sounds great! Can you just check it once it publishes to stable server? Great work, @Manasa2850 !! |
|
@jywarren the question cards are rendering fine! However, we can have some improvements in its design. Will discuss this with you in our next call. |
* refactor question card * fixed typo * fixed some of the failing tests
* refactor question card * fixed typo * fixed some of the failing tests
Fixes #8731 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!