Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emojis to labels to make them more friendly #9650

Merged
merged 2 commits into from
May 27, 2021
Merged

Add emojis to labels to make them more friendly #9650

merged 2 commits into from
May 27, 2021

Conversation

bajajvinamr
Copy link
Contributor

@bajajvinamr bajajvinamr commented May 20, 2021 •
edited
Loading

Add emojis to labels to make them more friendly

Fixes #9539

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!
Here is how the labels readme will look from now on!
image

@bajajvinamr
Update LABELS.md
0d42c1d 
Add emojis to labels to make them more friendly
@gitpod-io
Copy link

gitpod-io bot commented May 20, 2021

@bajajvinamr
Copy link
Contributor Author

@publiclab/reviewers @Manasa2850 if you can review the pr!

@codecov
Copy link

codecov bot commented May 20, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@0837f34). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f356392 differs from pull request most recent head b2caf46. Consider uploading reports for the commit b2caf46 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9650   +/-   ##
=======================================
  Coverage        ?   48.60%           
=======================================
  Files           ?       98           
  Lines           ?     6108           
  Branches        ?        0           
=======================================
  Hits            ?     2969           
  Misses          ?     3139           
  Partials        ?        0

Manasa2850
Manasa2850 requested changes May 21, 2021
View reviewed changes
doc/LABELS.md Outdated
* Labels like ` HTML ` , ` CSS ` , ` Ruby ` and ` JavaScript ` tell the **programming language** of the issue.
* ` design ` - This says that the issue requires more design work and discussion (i.e. mockups and sketches).
* ` documentation ` - This tells that a certain feature lacks proper documentation or needs more documents. :orange_book:
* ` testing ` - These issues are usually for adding `unit tests`, `integration tests` or any other tests for a particular feature/program. :heavy_check_mark:
* ` outreach ` - The outreach issues involve community involvement and helping people who're stuck somewhere.
* ` outreach ` - The outreach issues involve community involvement and helping people who're stuck somewhere. :tada: :raising_hand_man:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bajajvinamr could you remove the extra space before *?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

committed the change

@codeclimate
Copy link

codeclimate bot commented May 21, 2021

Code Climate has analyzed commit b2caf46 and detected 0 issues on this pull request.

View more on Code Climate.

@Manasa2850 Manasa2850 closed this May 21, 2021
@Manasa2850 Manasa2850 reopened this May 21, 2021
@Manasa2850
Copy link
Member

I'm not sure why the unit test is failing. It's not related to this PR. Will look more into that.
Thanks for working on this @bajajvinamr 🎉

@cesswairimu cesswairimu reopened this May 21, 2021
@bajajvinamr
Copy link
Contributor Author

I'm not sure why the unit test is failing. It's not related to this PR. Will look more into that.
Thanks for working on this @bajajvinamr 🎉

thanks a lot for the help! @Manasa2850

@cesswairimu
Copy link
Collaborator

I will try to restart again

@cesswairimu cesswairimu reopened this May 24, 2021
@jywarren
Copy link
Member

Aha - this is documented in the comments of #9665 (comment) - it's unrelated, apologies! Hopefully we have a PR fix shortly. Thanks for your patience!

@cesswairimu
Copy link
Collaborator

Attempting to fix this over here #9681. thanks

@cesswairimu cesswairimu reopened this May 27, 2021
@cesswairimu cesswairimu merged commit ece2611 into publiclab:main May 27, 2021
@welcome
Copy link

welcome bot commented May 27, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@cesswairimu
Copy link
Collaborator

Thanks everyone 🎉 🎉 🎉

@jywarren
Copy link
Member

Thanks for your patience everyone!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@bajajvinamr @reginaalyssa
Add emojis to labels to make them more friendly (publiclab#9650)
0b00986 
* Update LABELS.md

Add emojis to labels to make them more friendly

* Update LABELS.md
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@bajajvinamr @billymoroney1
Add emojis to labels to make them more friendly (publiclab#9650)
e897e8d 
* Update LABELS.md

Add emojis to labels to make them more friendly

* Update LABELS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manasa2850 Manasa2850 Manasa2850 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add emojis to labels to make them more friendly
4 participants
@bajajvinamr @Manasa2850 @cesswairimu @jywarren