-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translation function in app/views/layouts/_header.html.erb #7744
Conversation
Changed function t to translation.
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## master #7744 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 97 97
Lines 5627 5627
=======================================
Hits 4611 4611
Misses 1016 1016 |
Hi @WaldenJosh thanks so much for opening this 🎉 could you please add the issue link to the issue this pull request fixes on your pull request on this line "Fixes issue_link" this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks |
Awesome job, boy that was quick! Congrats on your first contribution! Adding to @cesswairimu , just to keep in mind for next time: Instead of naming your commit to Update _header.html.erb, it would be better if you named it Update app/views/layouts/_header.html.erb. This will clear up confusion because we also have _header.html.erb in the app/views/wiki folder. This will aid in those who are scanning the PR titles from the main tab. |
This pull request should be good to go now. Thank you for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🎉 🎉
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Welcome to PublicLab @WaldenJosh 🎈 |
Thank you for the opportunity to help. I am definitely interested in helping out wherever I can. |
Changed function t to translation.
Hi all, thank you SO MUCH -- i just referenced this when noting there may have been some issues with the string parsing done here. I don't know if you have any availability to help us figure this out? Thanks again for your great work! #7798 I think possibly we need some more careful checking before merging these, and I included in #7798 a URL for turning translations on locally so that people can do this. Any help appreciated!!! |
Changed function t to translation.
Fixes #7726
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!