Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation function in app/views/layouts/_header.html.erb #7744

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Update translation function in app/views/layouts/_header.html.erb #7744

merged 1 commit into from
Mar 29, 2020

Conversation

WaldenJosh
Copy link
Contributor

@WaldenJosh WaldenJosh commented Mar 29, 2020

Changed function t to translation.

Fixes #7726

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Changed function t to translation.
@WaldenJosh WaldenJosh requested a review from a team as a code owner March 29, 2020 03:12
@welcome
Copy link

welcome bot commented Mar 29, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #7744 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7744   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          97       97           
  Lines        5627     5627           
=======================================
  Hits         4611     4611           
  Misses       1016     1016           

@cesswairimu
Copy link
Collaborator

Hi @WaldenJosh thanks so much for opening this 🎉 could you please add the issue link to the issue this pull request fixes on your pull request on this line "Fixes issue_link" this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks

@nicoleiocana
Copy link
Contributor

Awesome job, boy that was quick! Congrats on your first contribution!

Adding to @cesswairimu , just to keep in mind for next time:

Instead of naming your commit to Update _header.html.erb, it would be better if you named it Update app/views/layouts/_header.html.erb. This will clear up confusion because we also have _header.html.erb in the app/views/wiki folder. This will aid in those who are scanning the PR titles from the main tab.

@WaldenJosh WaldenJosh changed the title Update _header.html.erb Update translation function in app/views/layouts/_header.html.erb Mar 29, 2020
@WaldenJosh
Copy link
Contributor Author

This pull request should be good to go now. Thank you for the help!

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🎉 🎉

@cesswairimu cesswairimu merged commit 320949e into publiclab:master Mar 29, 2020
@welcome
Copy link

welcome bot commented Mar 29, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@cesswairimu
Copy link
Collaborator

Welcome to PublicLab @WaldenJosh 🎈

@WaldenJosh WaldenJosh deleted the patch-1 branch March 29, 2020 17:35
@WaldenJosh
Copy link
Contributor Author

Thank you for the opportunity to help. I am definitely interested in helping out wherever I can.

icarito pushed a commit that referenced this pull request Mar 31, 2020
Changed function t to translation.
@jywarren
Copy link
Member

jywarren commented Apr 8, 2020

Hi all, thank you SO MUCH -- i just referenced this when noting there may have been some issues with the string parsing done here. I don't know if you have any availability to help us figure this out? Thanks again for your great work! #7798

I think possibly we need some more careful checking before merging these, and I included in #7798 a URL for turning translations on locally so that people can do this. Any help appreciated!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change function t to translation in app/views/layouts/_header.html.erb
5 participants