-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing non-working links at profile page #5192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shubhi2000 Can we have a descriptive PR name explaining the changes done in few words instead of update show.html.erb
Generated by 🚫 Danger |
@CleverFool77 yeah sure. Is it possible for me to make changes in the name now? |
@gauravano I think this is good to be merged! |
Co-Authored-By: shubhi2000 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @shubhi2000!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Merged 💯 🎉 🎈 |
Thank you soo much @gauravano, @CleverFool77, @madeofhuman , @IshaGupta18 for helping me out. |
* Update show.html.erb * Fixing non-working links at profile page Co-Authored-By: shubhi2000 <[email protected]>
* Update show.html.erb * Fixing non-working links at profile page Co-Authored-By: shubhi2000 <[email protected]>
* Update show.html.erb * Fixing non-working links at profile page Co-Authored-By: shubhi2000 <[email protected]>
* Update show.html.erb * Fixing non-working links at profile page Co-Authored-By: shubhi2000 <[email protected]>
Fixes #5021 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!