Try not to mount app directory only /public/system

[icarito]

Intends to fix #3261 and also possibly #4849 and other issues arising from mountint the app dir as a volume in container.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• PR is descriptively titled 📑
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[plotsbot]

	2 Messages
📖	@icarito Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[icarito]

This is passing now! I'll test it out in unstable, @jywarren please review if https://github.com/icarito/plots2/blob/not_mount_app_volume/containers/docker-compose-production.yml#L40-L45 sounds like all directories needed at runtime for writing.

[icarito]

Tried this in unstable and found 404 for public/system files, investigating...

[icarito]

Issue was with assets precompilation. This is running in unstable now please try it out!

[grvsachdeva]

Hi @icarito, please update the status of the issue. Thanks!

[icarito]

This is the main insight to put assets inside the Docker container. This way we can push to production without running bundler / yarn in production.

[icarito]

Hi! I believe this is ready for merging - it does change fundamentally how we treat assets and in particular how we access local files (specific needed directories only are "mounted") - all else will be inside the container.
We should test this out in unstable - to confirm stuff like uploading files works in all instances.
This is a step in the direction of deploying pre-built containers to production instead of building them on the production server. Also it should fix issues with Gemfile.lock and Yarn.lock when deploying, that @jywarren reported.

[icarito]

Except travis just failed on it, checking again!

[icarito]

Wow it looks like since I made this, we upgraded to a version of rails that doesn't use initialize_on_precompile=false which is what I was doing to be able to compile assets without a database.
I need to find a workaround.

[icarito]

There is a workaround for this detailed here:

passing a dummy database config while precompiling:

bundle exec rake RAILS_ENV=staging DATABASE_URL=mysql2://none:[email protected]/none assets:precompile

I think we need #5422 in order to have a workaround for this. So this is stuck for the moment.

[stale]

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈.