Fixed Show more of table

[shubhscoder]

Fixes #3654

Problem:
There were some problems in the show more button on the learn more page of infragram.

1. Let's say that there were 10 more items to be viewed in the table, the show more button said "Show 10 more items". Now,even after the user has clicked that once, it said the same text "Show 10 more items", which may confuse the user.

2.If there were exact 10 items in the table then the show more button said "Show 0 more items" which doesn't make much sense.

Changes Proposed:

1. Once the user clicks the button the text vanishes.
2. Also the button is displayed only in case there are strictly more than 10 items in the table. This fixes the second problem.

Since views were changed, the relevant screen shots are attached.

[plotsbot]

	1 Message
📖	@shubhscoder Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[jywarren]

Great! Can you share a screenshot? Thank you!!!

…

On Wed, Oct 31, 2018 at 10:34 AM Shubham Sangamnerkar < ***@***.***> wrote: Fixes #3654 <#3654> Problem: There were some problems in the show more button on the learn more page of infragram. 1. Let's say that there were 10 more items to be viewed in the table, the show more button said "Show 10 more items". Now,even after the user has clicked that once, it said the same text "Show 10 more items", which may confuse the user. 2.If there were exact 10 items in the table then the show more button said "Show 0 more items" which doesn't make much sense. Changes Proposed: 1. Once the user clicks the button the text vanishes. 2. Also the button is displayed only in case there are strictly more than 10 items in the table. This fixes the second problem. Since views were changed, the relevant screen shots are attached. Proposed solution: ------------------------------ You can view, comment on, or merge this pull request online at: #3866 Commit Summary - Fixed Show more of table File Changes - *M* app/views/grids/_notes.html.erb <https://github.com/publiclab/plots2/pull/3866/files#diff-0> (5) Patch Links: - https://github.com/publiclab/plots2/pull/3866.patch - https://github.com/publiclab/plots2/pull/3866.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3866>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ3X2sWYby7cKnSdkR6A2si9pSNhZks5uqbTwgaJpZM4YENgW> .

[shubhscoder]

@jywarren ,I have already shared the screenshots . Am I missing out on something, because I am able to see the screenshots 😅

[jywarren]

Ah my apologies, i had responded by email and didn't see them! 😄

This is great careful work! Does this work if you click it again? See how .toggle() affects turning this on and off, by toggling the hide class? Just want to be sure your change works with repeated interactions. If you can post a gif (#3513) that can help clarify!

Great work, thank you!!

[shubhscoder]

You can't click repeatedly. Because as you click on show more once the element actually disappears. Do you think we should implement the show more and show less both ?

…

On Fri, Nov 2, 2018, 12:59 AM Jeffrey Warren ***@***.***> wrote: Ah my apologies, i had responded by email and didn't see them! 😄 This is great careful work! Does this work if you click it again? See how .toggle() affects turning this on and off, by toggling the hide class? Just want to be sure your change works with repeated interactions. If you can post a gif (#3513 <#3513>) that can help clarify! Great work, thank you!! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3866 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARofxQsRBlBhL6v6z7uoBkPMjmIHuBazks5uq0uMgaJpZM4YENgW> .

[shubhscoder]

And yes , I ll make a put a gif 🙈 On Fri, Nov 2, 2018, 7:48 AM shubham sangamnerkar < [email protected]> wrote:

…

You can't click repeatedly. Because as you click on show more once the element actually disappears. Do you think we should implement the show more and show less both ? On Fri, Nov 2, 2018, 12:59 AM Jeffrey Warren ***@***.***> wrote: > Ah my apologies, i had responded by email and didn't see them! 😄 > > This is great careful work! Does this work if you click it again? See how > .toggle() affects turning this on and off, by toggling the hide class? > Just want to be sure your change works with repeated interactions. If you > can post a gif (#3513 <#3513>) > that can help clarify! > > Great work, thank you!! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3866 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ARofxQsRBlBhL6v6z7uoBkPMjmIHuBazks5uq0uMgaJpZM4YENgW> > . >

[shubhscoder]

So Sorry @jywarren for the delay. I had actually forgot about this. But now I have uploaded the gif

[jywarren]

no problem. the toggle explanation sounds great. Do you think this is ready for final review then? Thanks!!!

…

On Wed, Nov 14, 2018 at 7:23 AM Shubham Sangamnerkar < ***@***.***> wrote: [image: demo] <https://user-images.githubusercontent.com/18489285/48482197-0dab2c80-e836-11e8-9492-3232d430d427.gif> So Sorry @jywarren <https://github.com/jywarren> for the delay. I had actually forgot about this. But now I have uploaded the gif — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3866 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJxXsiSxH0Mq99Zk5B6rvnuLjwviWks5uvAs2gaJpZM4YENgW> .

[shubhscoder]

If the gif seems fine to you then this can be reviewed. Thank you!

[jywarren]

Looks super. Thanks a lot and great work!