Update blog post limit #3818
Update blog post limit #3818
Conversation
Generated by 🚫 Danger |
|
@publiclab/reviewers @jywarren |
app/controllers/tag_controller.rb
Outdated
| @@ -246,7 +246,8 @@ def widget | |||
| end | |||
|
|
|||
| def blog | |||
| nids = Tag.find_nodes_by_type(params[:id], 'note', 20).collect(&:nid) | |||
| blog_count = Tag.tagged_node_count('blog') | |||
There was a problem hiding this comment.
So sorry I missed this! I think we can actually skip this line and specify a length of nil -- that'll remove the limit!
|
@shubhangi-chauhan do you need any help on this issue? |
|
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it. |
|
I will complete this PR @SidharthBansal . Thanks! |
|
Great
…On Wed, Feb 13, 2019 at 4:20 PM Gaurav Sachdeva ***@***.***> wrote:
I will complete this PR @SidharthBansal
<https://github.com/SidharthBansal> . Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3818 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ19qDi4G1n4N4EbvLXP1Re4OsZ28ks5vM-3ZgaJpZM4X-Ktq>
.
|
Increased the limit on blog plots, set it to number of notes with tag 'blog'.
grvsachdeva
force-pushed
the
shubhangi-patch-1
branch
from
a693952 to
bd8d446
Compare
|
@jywarren also tested on unstable.publiclab.org too
|
|
Super, thank you!!!! |
|
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
* Update blog post limit Increased the limit on blog plots, set it to number of notes with tag 'blog'. * pasisng nil
* Update blog post limit Increased the limit on blog plots, set it to number of notes with tag 'blog'. * pasisng nil
* Update blog post limit Increased the limit on blog plots, set it to number of notes with tag 'blog'. * pasisng nil
Increased the limit on blog posts, set it to number of notes with tag 'blog'.
Fixes #3676 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!