Pop up menu is not updated without page refresh

[tsparksh]

Fixes #3370 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[plotsbot]

	2 Messages
📖	@thesparks Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[tsparksh]

@igniteeng000, @SidharthBansal, @jywarren please check.

like.js code is so strange :/ (changelikecount() and changenotlikecount() 😕 )

[tsparksh]

@tech4GT

[tech4GT]

@thesparks Sidharth is right, please try to keep the conversations as nice as possible😄
As for the code, I'll have a look. Thanks!

[tsparksh]

Sorry.
Any news about task?

[tsparksh]

???

[tech4GT]

@thesparks I'm sorry for the delay, I've been very busy with my university work for the past week, maybe @jywarren can help here. Thanks!

[jywarren]

Ah, this is a pretty interesting implementation! Could you try to demonstrate how it works in a gif, following these steps?

#3513

That helps us understand the UI sequence and flow. Thank you!

[jywarren]

Also, Code Climate is asking us to reduce the redundancy of the code. I think it's a good suggestion -- take a look! https://codeclimate.com/github/publiclab/plots2/pull/3810

[tsparksh]

@jywarren, I am sorry, I did not have time these days. I tried to remove the codeclimate-warn, but this code was written before me and I do not know how to fix it

[tsparksh]

@avsingh999 please check this too