Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed "and" to "&&" in code lines. #11550

Closed
wants to merge 1 commit into from
Closed

Changed "and" to "&&" in code lines. #11550

wants to merge 1 commit into from

Conversation

VijendraPandey
Copy link

I have solved the issue and made my first commit. Please review it.

@VijendraPandey VijendraPandey requested a review from a team as a code owner October 28, 2022 17:58
@welcome
Copy link

welcome bot commented Oct 28, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 28, 2022

codeclimate[bot]
codeclimate bot reviewed Oct 28, 2022
View reviewed changes
app/controllers/editor_controller.rb
@@ -35,12 +35,12 @@ def rich
@main_image = Image.find_by(id: params[:main_image]).path
end

if params[:tags]&.include? "lat:" and params[:tags]&.include? "lon:"
if params[:tags]&.include? "lat:" && params[:tags]&.include? "lon:"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected token tSTRING
(Using Ruby 2.5 parser; configure using TargetRubyVersion parameter, under AllCops)

@codeclimate
Copy link

codeclimate bot commented Oct 28, 2022

Code Climate has analyzed commit 9867a4e and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2

View more on Code Climate.

@VijendraPandey VijendraPandey deleted the patch-1 branch October 28, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VijendraPandey