Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace "and" with "&&" editor-controller #11549

Closed
wants to merge 1 commit into from
Closed

replace "and" with "&&" editor-controller #11549

wants to merge 1 commit into from

Conversation

liryyy
Copy link

@liryyy liryyy commented Oct 28, 2022

Fixes #11502

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁

@liryyy liryyy requested a review from a team as a code owner October 28, 2022 06:23
@welcome
Copy link

welcome bot commented Oct 28, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 28, 2022

@codeclimate
Copy link

codeclimate bot commented Oct 28, 2022

Code Climate has analyzed commit 082a472 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/9007205488/artifacts/415134349

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #11549 (082a472) into main (83e0439) will increase coverage by 6.61%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11549      +/-   ##
==========================================
+ Coverage   76.71%   83.33%   +6.61%     
==========================================
  Files          93       93              
  Lines        5772     5772              
==========================================
+ Hits         4428     4810     +382     
+ Misses       1344      962     -382     
Impacted Files Coverage Δ
app/controllers/editor_controller.rb 76.74% <100.00%> (ø)
app/controllers/relationships_controller.rb 71.42% <0.00%> (ø)
app/controllers/users_controller.rb 80.78% <0.00%> (+0.35%) ⬆️
app/controllers/spam2_controller.rb 72.54% <0.00%> (+0.98%) ⬆️
app/controllers/user_tags_controller.rb 83.78% <0.00%> (+1.35%) ⬆️
app/controllers/admin_controller.rb 80.24% <0.00%> (+1.64%) ⬆️
app/controllers/search_controller.rb 97.67% <0.00%> (+2.32%) ⬆️
app/models/revision.rb 88.29% <0.00%> (+3.19%) ⬆️
app/models/node_tag.rb 100.00% <0.00%> (+3.70%) ⬆️
app/models/user.rb 86.23% <0.00%> (+4.34%) ⬆️
... and 16 more

@cesswairimu
Copy link
Collaborator

Hi @liryyy, this issue was fixed on #11507. Please check the comments on the issue in future to see if someone is working on it before you start working on an issue. Closing this, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace "and" with "&&" editor-controller
2 participants