Update editor_controller.rb

[SylviaKaks]

Fixes #11502

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

[gitpod-io]

[codeclimate]

Code Climate has analyzed commit f7c897e and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8945199650/artifacts/410676180

[codecov]

Codecov Report

Merging #11544 (d8679bd) into main (3855d15) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d8679bd differs from pull request most recent head f7c897e. Consider uploading reports for the commit f7c897e to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11544   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          93       93           
  Lines        5772     5772           
=======================================
  Hits         4810     4810           
  Misses        962      962           

Impacted Files	Coverage Δ
app/controllers/editor_controller.rb	76.74% <100.00%> (ø)

[SylviaKaks]

@cesswairimu @jywarren @TildaDares kindly review this code change and advise accordingly - #11544 . Thanks

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8945449666/artifacts/410692927

[jywarren]

Hello, can you link us to the original issue for context? Thank you!

[SylviaKaks]

the original issue is #11502 @jywarren

[7malikk]

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Hey there @SylviaKaks, I believe what @jywarren meant was you should include the issue number in its allocated spot i.e "Fixes #issue-number" in the initial PR

[SylviaKaks]

@7malikk thanks for the observation. I have rectified it.
@jywarren kindly check out the code again, the issue link is included.

[cesswairimu]

Looks good 🎉 thanks @SylviaKaks for working on this. Thanks Jeff and @7malikk for the reviews ❤️

[cesswairimu]

oh @SylviaKaks seems you already worked on a fto and someone else was already working on this here #11507

another contributor working on this #11507

[SylviaKaks]

@cesswairimu . I wanna try out working on more issues that may not be for first timers only but need to be rectified, just that i dont know where to find the code to work on when i open those issues

[cesswairimu]

@SylviaKaks do you have one that you are interested in and maybe we can try point you to the files? if so, ping me on the issue comment with the question and we try figure them out.

[cesswairimu]

I will go ahead and close this