invert negation in if/else - relationships_controller #11505

Dhei-vid · 2022-10-17T18:27:18Z

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

welcome · 2022-10-17T18:27:20Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌

Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

gitpod-io · 2022-10-17T18:27:28Z

Dhei-vid · 2022-10-17T18:28:13Z

@cesswairimu I have opened a pull request for the task. Please check and confirm. Thank you.

codeclimate · 2022-10-17T18:28:20Z

app/controllers/relationships_controller.rb

        format.html {
          flash[:error] = "Error in following user"
          redirect_to URI.parse(request.referer || "/").path
        }
        format.js { render "create", locals: { following: false, profile_user: user } }
+      else 


Trailing whitespace detected.

codeclimate · 2022-10-17T18:28:20Z

app/controllers/relationships_controller.rb

        format.html {
          flash[:error] = "Error in unfollowing user"
          redirect_to URI.parse(request.referer || "/").path
        }
        format.js { render "destroy", locals: { unfollowing: false, profile_user: user } }
+      else 


Trailing whitespace detected.

github-actions · 2022-10-17T18:58:47Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8817247861/artifacts/401347212

codecov · 2022-10-19T16:19:28Z

Codecov Report

Merging #11505 (1a9a313) into main (21dfe4c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11505      +/-   ##
==========================================
- Coverage   83.33%   83.31%   -0.02%     
==========================================
  Files          93       93              
  Lines        5772     5773       +1     
==========================================
  Hits         4810     4810              
- Misses        962      963       +1

Impacted Files	Coverage Δ
app/controllers/relationships_controller.rb	`71.42% <100.00%> (ø)`
app/models/user.rb	`86.23% <0.00%> (-0.27%)`	⬇️
app/controllers/home_controller.rb	`95.58% <0.00%> (-0.07%)`	⬇️
app/channels/user_channel.rb	`83.33% <0.00%> (ø)`
app/controllers/notes_controller.rb	`85.76% <0.00%> (ø)`

github-actions · 2022-10-19T17:34:57Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8859208127/artifacts/404315930

github-actions · 2022-10-19T18:19:29Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8859970939/artifacts/404367091

codeclimate · 2022-10-19T18:22:18Z

Code Climate has analyzed commit 1a9a313 and detected 0 issues on this pull request.

View more on Code Climate.

github-actions · 2022-10-19T18:31:56Z

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8860197559/artifacts/404383411

Dhei-vid · 2022-10-19T19:33:04Z

Hello @cesswairimu, I have completed the task could you check and verify. Thanks

TildaDares · 2022-10-21T11:38:43Z

Hi @Dhei-vid, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

cesswairimu

Looking great 🎉 Thanks for working on this @Dhei-vid .
I've updated the issue number on the description. Kindly update the issue number in future pull requests where we have Fixes #0000 as Tilda mentioned. It helps when reviewing and to auto close the issue once merged.

welcome · 2022-10-21T11:57:58Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

Dhei-vid · 2022-10-21T13:51:06Z

Looking great 🎉 Thanks for working on this @Dhei-vid . I've updated the issue number on the description. Kindly update the issue number in future pull requests where we have Fixes #0000 as Tilda mentioned. It helps when reviewing and to auto close the issue once merged.

Noted. Thank you @cesswairimu @TildaDares

invert negation in if/else

113f698

codeclimate bot reviewed Oct 17, 2022

View reviewed changes

Dhei-vid added 2 commits October 17, 2022 19:34

invert negation in if/else

43dceea

invert negation in if/else

ac8362f

invert negation in if/else

90ebd7b

Dhei-vid added 3 commits October 19, 2022 17:20

invert negation in if/else

c1b9367

invert negation in if /else

c78fa33

invert negation in if /else

5c7ffcc

invert negation in if /else

d518401

invert negation in if/else

1a9a313

cesswairimu approved these changes Oct 21, 2022

View reviewed changes

cesswairimu merged commit a5aecc3 into publiclab:main Oct 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

invert negation in if/else - relationships_controller #11505

invert negation in if/else - relationships_controller #11505

Dhei-vid commented Oct 17, 2022 •

edited by cesswairimu

Loading

welcome bot commented Oct 17, 2022

gitpod-io bot commented Oct 17, 2022

Dhei-vid commented Oct 17, 2022

codeclimate bot Oct 17, 2022

codeclimate bot Oct 17, 2022

github-actions bot commented Oct 17, 2022

codecov bot commented Oct 19, 2022 •

edited

Loading

github-actions bot commented Oct 19, 2022

github-actions bot commented Oct 19, 2022

codeclimate bot commented Oct 19, 2022

github-actions bot commented Oct 19, 2022

Dhei-vid commented Oct 19, 2022

TildaDares commented Oct 21, 2022

cesswairimu left a comment

welcome bot commented Oct 21, 2022

Dhei-vid commented Oct 21, 2022

invert negation in if/else - relationships_controller #11505

invert negation in if/else - relationships_controller #11505

Conversation

Dhei-vid commented Oct 17, 2022 • edited by cesswairimu Loading

welcome bot commented Oct 17, 2022

gitpod-io bot commented Oct 17, 2022

Dhei-vid commented Oct 17, 2022

codeclimate bot Oct 17, 2022

Choose a reason for hiding this comment

codeclimate bot Oct 17, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 17, 2022

codecov bot commented Oct 19, 2022 • edited Loading

Codecov Report

github-actions bot commented Oct 19, 2022

github-actions bot commented Oct 19, 2022

codeclimate bot commented Oct 19, 2022

github-actions bot commented Oct 19, 2022

Dhei-vid commented Oct 19, 2022

TildaDares commented Oct 21, 2022

cesswairimu left a comment

Choose a reason for hiding this comment

welcome bot commented Oct 21, 2022

Dhei-vid commented Oct 21, 2022

Dhei-vid commented Oct 17, 2022 •

edited by cesswairimu

Loading

codecov bot commented Oct 19, 2022 •

edited

Loading