update app/controllers/home_controller.rb file for issue rubocop fixes - home controller #11499 #11503
Conversation
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/controllers/home_controller.rb
Outdated
| @@ -98,7 +98,7 @@ def activity | |||
| .page(params[:page]) | |||
| .group(['title', 'comments.cid']) # ONLY_FULL_GROUP_BY, issue #3120 | |||
|
|
|||
| if logged_in_as(['admin', 'moderator']) | |||
| if logged_in_as((%w(moderator admin))) | |||
There was a problem hiding this comment.
Don't use parentheses around a literal.
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Hello @cesswairimu, the bot prevented the code from being merged after doing exactly what I was ask to do. Do you have any suggestions on how I can make it right please? |
app/controllers/home_controller.rb
Outdated
| @@ -98,7 +98,7 @@ def activity | |||
| .page(params[:page]) | |||
| .group(['title', 'comments.cid']) # ONLY_FULL_GROUP_BY, issue #3120 | |||
|
|
|||
| if logged_in_as(['admin', 'moderator']) | |||
| if logged_in_as((%w(moderator admin))) | |||
There was a problem hiding this comment.
Hi @Dorcas-BD , my bad I included extra braces .. it should be if logged_in_as (%w(moderator admin)). please make the change, thanks
There was a problem hiding this comment.
but that shouldn't be affecting the tests though 🤔
|
Code Climate has analyzed commit 7b9e2a2 and detected 0 issues on this pull request. View more on Code Climate. |
Fixes #11499
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below