-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map floats over the footer while scrolling! - UI Bug #10358
Conversation
This reverts commit 2c37fad.
Codecov Report
@@ Coverage Diff @@
## main #10358 +/- ##
==========================================
- Coverage 82.11% 81.99% -0.12%
==========================================
Files 98 98
Lines 5982 5982
==========================================
- Hits 4912 4905 -7
- Misses 1070 1077 +7
|
Hi @jywarren, I have followed your steps. Is it fine now? |
Code Climate has analyzed commit 1323436 and detected 0 issues on this pull request. View more on Code Climate. |
/rebase |
This looks really good, my apologies for missing it in my notifications! Just rebasing to get past the test issues, which i think are unrelated. Let's see! 🤞 |
Hi, would you mind rebasing this over the latest main branch? i can't seem to do it easily from my end. That will resolve the test! Apologies and thanks! |
Hi @jywarren , Can you please guide me about rebasing it to the main branch? Thank you! |
Hi @wajeehamushtaq of course, sorry for the slow response!
Thanks! |
Hey @wajeehamushtaq feel free to ping in case you are running into any issues. We are here to help ✌️ |
Hi @wajeehamushtaq, we are unable to move forward without a rebase here, we understand you might be busy and engaged on other things. The solution was great and I will use the solution to convert the issue to a first-timer issue - thanks for working on this. Please feel free to come back anytime and ask for another issue to work on. Closing this. Thanks all |
Fixes #10306
I try to fix the Map floats over the footer while scrolling! - UI Bug (1/3). The problem arise due to leaflet map styling. The position is set to absolute so this will create the problem.